-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated fixes #2312
base: v0.7.0
Are you sure you want to change the base?
Deprecated fixes #2312
Conversation
Thanks. HCompCurve is still used on OCCT versions under 7.6, which is still the default on e.g most linux distros. So for the code to remain compatible the deleted include also needs to be conditional wrt OCCT version. https://github.com/IfcOpenShell/IfcOpenShell/blob/v0.7.0/src/ifcgeom/IfcTrimmedCurve.cpp#L58 See CI Failure: https://github.com/IfcOpenShell/IfcOpenShell/runs/7495267968?check_suite_focus=true#step:5:660 |
@aothms how are these things checked within QA? |
We just have some CI scripts in github actions. Currently they compile against 7.5 as that's what the distros provide and compiling occt in the github action would be prohibitive in terms of runtime https://github.com/IfcOpenShell/IfcOpenShell/blob/v0.7.0/.github/workflows/ci.yml#L44 |
This still gives me deprecation warnings. (This was due to the missing Standard_Version.hxx) |
Uncovered a bug in the existing code while fixing this :-) |
One annoying complition error, and some deprecation warnings.