New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark client struct parameters as const in _create() functions #24

Merged
merged 2 commits into from Oct 3, 2018

Conversation

Projects
None yet
2 participants
@aperezdc
Copy link
Member

aperezdc commented Oct 3, 2018

The client structs are used vtables, which in shouldn't change, so the parameters to the *_create() functions can be marked const.

aperezdc added some commits Aug 20, 2018

@aperezdc aperezdc requested review from zdobersek and elima Oct 3, 2018

@aperezdc aperezdc changed the title Mark Mark client struct parameters as const in _create() functions Oct 3, 2018

@zdobersek zdobersek merged commit 9963f4e into master Oct 3, 2018

@aperezdc aperezdc deleted the constify-clients branch Oct 3, 2018

@aperezdc aperezdc added this to the Version 1.0.1 milestone Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment