-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch and don't throw from "toString" methods for IA2 and Atspi #213
Comments
For example, when getting some node data on some nodes in libreoffice, we are getting error codes from the IA2 API. For example, IAAction::toString throws on a menu item:
And this failure:
|
When we encounter an error, we should print it in the string, for example, |
It turns out it is very difficult to get Atspi to return an error message, error messages are only returned in special cases. We do get a lot of warnings thrown out to the terminal from these kinds of checks in the Atspi code instead: https://docs.gtk.org/glib/warnings.html Other places it throws errors (like Orca inspects to see if an object is dead) will usually happening when processing an event queue for objects that no longer exist, which will happen less often in a testing library. However, I think we do need to do this change in IA2, as it clearly returns errors more often. |
Joanie mentioned wanting to print all the data we could get on a tree, and not stopping if something returns an error.
Maybe the "toString" can print information, and not throw, to be used for this purpose.
The text was updated successfully, but these errors were encountered: