Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebView settings command-line pass-through #27

Closed
philn opened this issue Jun 6, 2018 · 1 comment
Closed

WebView settings command-line pass-through #27

philn opened this issue Jun 6, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@philn
Copy link
Member

philn commented Jun 6, 2018

Something like WebKitGTK's MiniBrowser would be nice to have, along with a --help-websettings option.

@aperezdc aperezdc added the enhancement New feature or request label Jun 10, 2018
@aperezdc aperezdc self-assigned this Jun 10, 2018
@aperezdc
Copy link
Member

This is quite a neat idea, I will be implementing this. Thanks for the suggestion!

aperezdc added a commit that referenced this issue Jun 11, 2018
This adds code to introspect properties of a give GObjectClass
and obtain a set of GOptionEntry instances which, when added to
a GOptionGroup, will set the values of the properties from the
parsed command line options.

Then, the above utility code is used to expose the properties from
WebKitSettings in a generic way, instead of having to manually add
a GOptionEntry and handling for each settings.

The following CLI options are replaced by the new functionality,
which covers the corresponding settings:

  --webgl          becomes --enable-webgl=1
  -D/--dev-tools   becomes --enable-developer-extras=1
  -v/--log-console becomes --enable-write-console-messages-to-stdout=1

Closes #27
aperezdc added a commit that referenced this issue Jun 11, 2018
This adds code to introspect properties of a given GObjectClass
and obtain a set of GOptionEntry instances which, when added to
a GOptionGroup, will set the values of the properties from the
parsed command line options.

Then, the above utility code is used to expose the properties from
WebKitSettings in a generic way, instead of having to manually add
a GOptionEntry and handling for each settings.

The following CLI options are replaced by the new functionality,
which covers the corresponding settings:

  --webgl          becomes --enable-webgl=1
  -D/--dev-tools   becomes --enable-developer-extras=1
  -v/--log-console becomes --enable-write-console-messages-to-stdout=1

Closes #27
aperezdc added a commit that referenced this issue Jun 11, 2018
This adds code to introspect properties of a given GObjectClass
and obtain a set of GOptionEntry instances which, when added to
a GOptionGroup, will set the values of the properties from the
parsed command line options.

Then, the above utility code is used to expose the properties from
WebKitSettings in a generic way, instead of having to manually add
a GOptionEntry and handling for each settings.

The following CLI options are replaced by the new functionality,
which covers the corresponding settings:

  --webgl          becomes --enable-webgl=1
  -D/--dev-tools   becomes --enable-developer-extras=1
  -v/--log-console becomes --enable-write-console-messages-to-stdout=1

Closes #27
@philn philn closed this as completed in #29 Jun 11, 2018
elima pushed a commit that referenced this issue Jun 13, 2018
This adds code to introspect properties of a given GObjectClass
and obtain a set of GOptionEntry instances which, when added to
a GOptionGroup, will set the values of the properties from the
parsed command line options.

Then, the above utility code is used to expose the properties from
WebKitSettings in a generic way, instead of having to manually add
a GOptionEntry and handling for each settings.

The following CLI options are replaced by the new functionality,
which covers the corresponding settings:

  --webgl          becomes --enable-webgl=1
  -D/--dev-tools   becomes --enable-developer-extras=1
  -v/--log-console becomes --enable-write-console-messages-to-stdout=1

Closes #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants