Provide command line options for WebKitSettings properties #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philn
approved these changes
Jun 11, 2018
core/cog-utils.c
Outdated
| const gboolean prop_value = !(value && | ||
| g_ascii_strcasecmp (value, "true") && | ||
| strcmp (value, "1")); | ||
| g_printerr ("set %s=%s\n", option, prop_value ? "true" : "false"); |
There was a problem hiding this comment.
You're right, good catch! Let's remove this before merging 👍
This adds code to introspect properties of a given GObjectClass and obtain a set of GOptionEntry instances which, when added to a GOptionGroup, will set the values of the properties from the parsed command line options. Then, the above utility code is used to expose the properties from WebKitSettings in a generic way, instead of having to manually add a GOptionEntry and handling for each settings. The following CLI options are replaced by the new functionality, which covers the corresponding settings: --webgl becomes --enable-webgl=1 -D/--dev-tools becomes --enable-developer-extras=1 -v/--log-console becomes --enable-write-console-messages-to-stdout=1 Closes #27
Instead of directly using the type names provided by GType, use uppercase strings for the value placeholders in help texts, which makes the output from --help-websettings more easily readable and provide a few lines with explanations for the available input formats.
aperezdc
force-pushed
the
cog-websettings-cli
branch
from
fbe6cc6
to
72b2818
Compare
|
I've added a small commit on top to provide a nicer formatting of the help output when using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds code to introspect properties of a given
GObjectClassand obtain a set ofGOptionEntryinstances which, when added to aGOptionGroup, will set the values of the properties from the parsed command line options.Then, the above utility code is used to expose the properties from
WebKitSettingsin a generic way, instead of having to manually add aGOptionEntryand handling for each settings.The following CLI options are replaced by the new functionality, which covers the corresponding settings:
--webgl--enable-webgl=1-D--dev-tools--enable-developer-extras=1-v--log-console--enable-write-console-messages-to-stdout=1Closes #27