Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] - Filter shows by unfinished #845

Closed
Jacob-Tate opened this issue May 23, 2024 · 6 comments · Fixed by #877
Closed

[FEATURE REQUEST] - Filter shows by unfinished #845

Jacob-Tate opened this issue May 23, 2024 · 6 comments · Fixed by #877

Comments

@Jacob-Tate
Copy link
Contributor

It would be nice to be able to go into shows and see what shows I havent finished yet. For example a show came out with new episodes since I last watched it.

@DickenSerm
Copy link

That's a good idea and I would also find it great.

@IgnisDa
Copy link
Owner

IgnisDa commented Jun 1, 2024

Note to self: add a is_metadata_finished column to user_to_entity or replace Seen in media_reason to Finished and change the logic for it.

@Jacob-Tate
Copy link
Contributor Author

For some reason the media_reason never gets set to finished no matter how many times I mark the show as watched. I need to manually edit my pgsql db to mark it as Finished. Is this intended behavior it doesnt appear to work this way on the demo instance.

I have confirmed this by removing the last episode of a show and readding it as watched and did not see the media_reason switch to finished.

@IgnisDa
Copy link
Owner

IgnisDa commented Jul 5, 2024

@Jacob-Tate The media_reason is updated by the nightly cron job. I recommend you wait for 24 hrs and if the problem still persists, then please ping me here.

@Jacob-Tate
Copy link
Contributor Author

@IgnisDa This appears to be related to a bug which occurs sometimes where a show will think its in progress even when youve seen the entire show. For example:
This show is 100% complete
image

But when updating it appears to think the show is in progess
image

I have done some testing and it appears if anything other than the most recent episode is the most recently updated thing in history it confuses the media_reason which normally isnt an issue but if you watch specials after you finish the show this will confuse the media_reason.

@IgnisDa
Copy link
Owner

IgnisDa commented Jul 7, 2024

The algorithm to determine if a show is completed is pretty naive. It just checks if all episodes (excluding specials) are watched an equal number of times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants