Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopening filtering causes errors #10048

Closed
michalsgit opened this issue Aug 23, 2021 · 6 comments · Fixed by #10080
Closed

Reopening filtering causes errors #10048

michalsgit opened this issue Aug 23, 2021 · 6 comments · Fixed by #10080
Assignees
Labels
🐛 bug Any issue that describes a bug 🔥 severity: high grid: filter-ui version: 11.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@michalsgit
Copy link

Description

Reopening filtering expression causes errors

  • igniteui-angular version: 12.1.1
  • browser: Chrome

Steps to reproduce

  1. Got to filtering demo here

  2. Open console

  3. Click on filter in column "Discontinued"

  4. Choose "True" OR "False "and click "Close" (same result will be with AND operand, too)

  5. Click again on the filter

Result

Error occures:
preview-f4664a6cfd526d580909b.js:1 ERROR TypeError: Cannot read property 'iconName' of null
at Object.eval [as updateDirectives] (IgxGridFilteringCellComponent.html:19)
at Object.debugUpdateDirectives [as updateDirectives] (services.ts:390)
at checkAndUpdateView (view.ts:372)
at callViewAction (view.ts:628)
at execEmbeddedViewsAction (view.ts:593)
at checkAndUpdateView (view.ts:373)
at callViewAction (view.ts:628)
at execEmbeddedViewsAction (view.ts:593)
at checkAndUpdateView (view.ts:373)
at callViewAction (view.ts:628)

Expected result

No error should occure.

Attachments

Attach
filter-error

@michalsgit michalsgit added the 🐛 bug Any issue that describes a bug label Aug 23, 2021
@gedinakova gedinakova added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Aug 25, 2021
astaev added a commit that referenced this issue Aug 31, 2021
kdinev added a commit that referenced this issue Sep 3, 2021
@gedinakova gedinakova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Sep 7, 2021
kdinev added a commit that referenced this issue Sep 7, 2021
kdinev added a commit that referenced this issue Sep 7, 2021
@domJalb
Copy link

domJalb commented Sep 13, 2021

This same bug is in version 11

@michalsgit
Copy link
Author

Still does not work in version 12.1.6

@kdinev
Copy link
Member

kdinev commented Sep 14, 2021

@domJalb Reopening. The changes will be propagated to 11.1.x and available in patch 11.1.26.

@astaev Please cherry-pick the fix in 11.1.x

@kdinev kdinev reopened this Sep 14, 2021
@kdinev
Copy link
Member

kdinev commented Sep 14, 2021

@michalsgit Did you just update? It could be a cache issue. @onlyexeption Could you retest again with 12.1.x?

@michalsgit
Copy link
Author

@kdinev You are right, it was problem with the cache. Now it works. Thanks.

@kdinev
Copy link
Member

kdinev commented Sep 14, 2021

@onlyexeption You can ignore my previous comment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug 🔥 severity: high grid: filter-ui version: 11.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants