Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The progressbar is not correctly visualized when it is templated by grid column. #1997

Closed
Aleksandyr opened this issue Jul 13, 2018 · 1 comment
Assignees
Labels
🐛 bug Any issue that describes a bug circular-progress 🧨 severity: medium progress-bar version: 6.2.x version: 7.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@Aleksandyr
Copy link
Contributor

Description

The progressbar is not correctly visualized when it is templated within grid cell.

  • igniteui-angular version: 6.1.x
  • browser: All

Steps to reproduce

  1. Open some of the grid demos
  2. Create some column with templated cell which contains progressbar
  3. Observe the templated cell

Result

The progressbar exceeds or shrinks within the cell.

Expected result

The progressbar should be correctly rendered.

Attachments

capture
capture1

@Aleksandyr Aleksandyr changed the title The progressbar is not correctly visualized when it is templated within grid cell. The progressbar is not correctly visualized when it is templated by grid column. Jul 13, 2018
@desig9stein desig9stein self-assigned this Nov 6, 2018
@desig9stein desig9stein added the 🛠️ status: in-development Issues and PRs with active development on them label Nov 6, 2018
@simeonoff simeonoff removed their assignment Nov 22, 2018
@desig9stein
Copy link
Contributor

@Aleksandyr in order for me to fix the problem I need some refactoring on the progress linear bar. The template has some extra wrapping div which needs to be removed and the class "progress-linear" needs to go to the host element, so instead of having this:

<igx-linear-bar>
     <div class="progress-linear" [class.progress-linear--striped]="striped">
           ...
     </div>
</igx-linear-bar>

It needs to look like this:

<igx-linear-bar class="progress-linear" [class.progress-linear--striped]="striped">
   ...
</igx-linear-bar>

The issue with the circular bar is fixed

screenshot 2018-11-23 at 15 45 01

@SlavUI The liniar progress bar needs some refactoring in order for this issue to be fixed.
Can you please take a look at the problem and decide when we should do the refactoring.

@desig9stein desig9stein removed the 🛠️ status: in-development Issues and PRs with active development on them label Nov 23, 2018
Aleksandyr added a commit that referenced this issue Dec 13, 2018
@rkaraivanov rkaraivanov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🆕 status: new labels Jan 7, 2019
@zdrawku zdrawku closed this as completed in b9b8f69 Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug circular-progress 🧨 severity: medium progress-bar version: 6.2.x version: 7.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

No branches or pull requests

5 participants