Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cell is not editable on iOS #2538

Closed
ymita opened this issue Sep 3, 2018 · 8 comments · Fixed by #3123 or #5542
Closed

Cell is not editable on iOS #2538

ymita opened this issue Sep 3, 2018 · 8 comments · Fixed by #3123 or #5542
Assignees
@damyanpetev @rkaraivanov
Labels
🐛 bug Any issue that describes a bug 🧨 severity: medium grid: general ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@ymita
Copy link
Contributor

ymita commented Sep 3, 2018 •
edited
Loading

Description

Cell is not editable on iOS

  • igniteui-angular version: 6.1.4
  • browser: Chrome 68.0.3440.83, Safari (iOS 11.4.1(15G77))

Steps to reproduce

  1. Go to https://www.infragistics.com/products/ignite-ui-angular/angular/components/grid_editing.html
  2. Try to edit a cell

Result

The cell does not go into edit mode.

Expected result

The cell goes into edit mode.
@ymita
Copy link
Contributor Author

ymita commented Sep 28, 2018

@zdrawku
Do you assume this issue will take a long time to fix? Or does this look like a straightforward one to fix? I appreciate any information about this issue.

@zdrawku
Copy link
Contributor

zdrawku commented Oct 1, 2018

@ymita today I will take a closer look and will let you know about all my findings regarding the issue.

@zdrawku zdrawku assigned tiliev and unassigned zdrawku Oct 4, 2018
@tiliev tiliev added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Oct 5, 2018
@tiliev
Copy link
Contributor

tiliev commented Oct 10, 2018

This is related to #angular/angular#23954, I pushed a PR. We'll implement a workaround for the time being.

tiliev pushed a commit that referenced this issue Oct 15, 2018
feat(igxGrid): iOS cell editing support #2538
5276bc8
tiliev pushed a commit that referenced this issue Oct 16, 2018
refactor(IgxGrid): Renaming doubletap event name. #2538
3192d1a
@zdrawku
Copy link
Contributor

zdrawku commented Nov 9, 2018

@tiliev could you make a PR to 6.2.x branch in order to review and test your implementation. Once the PR is present, change the status of this issue to resolved

@ymita we are goingto assign you as a reviewer as well.

tiliev pushed a commit that referenced this issue Nov 12, 2018
feat(igxGrid): iOS cell editing support #2538
403a198
@tiliev tiliev mentioned this issue Nov 12, 2018
Merged
tiliev pushed a commit that referenced this issue Nov 22, 2018
feat(igxGrid): iOS cell editing support #2538
d5d7d3f
@tiliev tiliev mentioned this issue Nov 22, 2018
Merged
14 tasks
zdrawku added a commit that referenced this issue Nov 26, 2018
@zdrawku
Merge pull request #2988 from IgniteUI/tiliev/ios-double-tap
a1ea04c 
feat(igxGrid): iOS cell editing support #2538
@rkaraivanov rkaraivanov assigned damyanpetev and rkaraivanov and unassigned tiliev Nov 28, 2018
@rkaraivanov
Copy link
Member

Unfortunately, this PR breaks other of our components which rely on hammerjs events. I'm reopening the issue and we should either extend our kind of forgotten hammer manager class to work with Angular, or hopefully the Angular team will add the doubletap support by default.

@rkaraivanov rkaraivanov reopened this Nov 28, 2018
@SlavUI SlavUI removed the 🛠️ status: in-development Issues and PRs with active development on them label Jan 17, 2019
@pnishimura
Copy link

pnishimura commented Jul 1, 2019 •
edited
Loading

Hi @zdrawku, @rkaraivanov @damyanpetev
Out of my curiosity,
Regarding this issue,
Is there no way rather then waiting for the doubletap support by the Angular team?
Or do we have any workaround for it?

@damyanpetev
Copy link
Member

damyanpetev commented Jul 1, 2019 •
edited
Loading

It does seem like this is taking a while to get resolved either by Angular or in iOS (one can dream) so we might as well try to fix it on our own for now.
There's an option to manually attach the double tab to HammerJS though one of our old manager class as @rkaraivanov said.
That'd require a bit refactoring at least. We'll look into it.

@pnishimura
Copy link

@damyanpetev Thank you for your reply!
Well understood now :)
As you mentioned, originally, this issue should be resolved by Angular or iOS, I think as well.
I'm glad to hear your comment this time.
This issue is not high priority thing,
But It would be great if you guys can let me know if any update around this issue in future.
Thank you again,
Paul

@damyanpetev damyanpetev added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jul 10, 2019
damyanpetev added a commit that referenced this issue Jul 17, 2019
@damyanpetev
fix(grids): handle double tap to allow editing on iOS #2538
4ae0dd1 
Since iOS WebKit doesn't support dblclick and Angular's Hammer plugin doesn't
have doubletap exposed, resorting to our Hammer manager. Also prevented the
double tap to zoom on the cell as it was rather jarring.
damyanpetev added a commit that referenced this issue Jul 18, 2019
@damyanpetev
fix(grids): handle double tap to allow editing on iOS #2538
6e92d40 
Since iOS WebKit doesn't support dblclick and Angular's Hammer plugin doesn't
have doubletap exposed, resorting to our Hammer manager. Also prevented the
double tap to zoom on the cell as it was rather jarring.
damyanpetev added a commit that referenced this issue Jul 18, 2019
@damyanpetev
fix(grids): handle double tap to allow editing on iOS #2538
937968d 
Since iOS WebKit doesn't support dblclick and Angular's Hammer plugin doesn't
have doubletap exposed, resorting to our Hammer manager. Also prevented the
double tap to zoom on the cell as it was rather jarring.
damyanpetev added a commit that referenced this issue Jul 18, 2019
@damyanpetev
fix(grids): handle double tap to allow editing on iOS #2538
a60a1f9 
Since iOS WebKit doesn't support dblclick and Angular's Hammer plugin doesn't
have doubletap exposed, resorting to our Hammer manager. Also prevented the
double tap to zoom on the cell as it was rather jarring.
damyanpetev added a commit that referenced this issue Jul 18, 2019
@damyanpetev
fix(grids): handle double tap to allow editing on iOS #2538
64590f7 
Since iOS WebKit doesn't support dblclick and Angular's Hammer plugin doesn't
have doubletap exposed, resorting to our Hammer manager. Also prevented the
double tap to zoom on the cell as it was rather jarring.
This was referenced Jul 18, 2019
Merged
Merged
Merged
Merged
@damyanpetev damyanpetev added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jul 18, 2019
Lipata added a commit that referenced this issue Aug 5, 2019
@Lipata
Merge pull request #5461 from IgniteUI/dpetev/ios-grid-edit-7-2
2e62f6e 
fix(grids): handle double tap to allow editing on iOS #2538
Lipata added a commit that referenced this issue Aug 5, 2019
@Lipata
Merge pull request #5462 from IgniteUI/dpetev/ios-grid-edit-7-3
83eabfa 
fix(grids): handle double tap to allow editing on iOS #2538
Lipata added a commit that referenced this issue Aug 5, 2019
@Lipata
Merge pull request #5463 from IgniteUI/dpetev/ios-grid-edit-8-0
7575b28 
fix(grids): handle double tap to allow editing on iOS #2538
Lipata added a commit that referenced this issue Aug 5, 2019
@Lipata
Merge pull request #5464 from IgniteUI/dpetev/ios-grid-edit-8-1
0e6607e 
fix(grids): handle double tap to allow editing on iOS #2538
@kdinev kdinev mentioned this issue Aug 5, 2019
Merged
damyanpetev added a commit that referenced this issue Sep 17, 2019
@damyanpetev
fix(grids): limit cell double tap handler to just iOS #2538
56f77ad
damyanpetev added a commit that referenced this issue Sep 17, 2019
@damyanpetev
perf(grids): limit cell double tap handler to just iOS #2538
236a6ce
damyanpetev added a commit that referenced this issue Sep 17, 2019
@damyanpetev
perf(grids): limit cell double tap handler to just iOS #2538
d41c149
damyanpetev added a commit that referenced this issue Sep 17, 2019
@damyanpetev
perf(grids): limit cell double tap handler to just iOS #2538
89d01d7
damyanpetev added a commit that referenced this issue Sep 17, 2019
@damyanpetev
perf(grids): limit cell double tap handler to just iOS #2538
14de710
damyanpetev added a commit that referenced this issue Sep 17, 2019
@damyanpetev
perf(grids): limit cell double tap handler to just iOS #2538
806bb59
damyanpetev added a commit that referenced this issue Sep 17, 2019
@damyanpetev
Merge pull request #5818 from IgniteUI/dpetev/ios-grid-edit-detect
57b9405 
perf(grids): limit cell double tap handler to just iOS #2538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damyanpetev damyanpetev

@rkaraivanov rkaraivanov

Labels
🐛 bug Any issue that describes a bug 🧨 severity: medium grid: general ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
8 participants
@damyanpetev @tiliev @zdrawku @ymita @rkaraivanov @pnishimura @SlavUI @ddincheva