Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell is not editable on iOS #2538

Closed
ymita opened this issue Sep 3, 2018 · 8 comments

Comments

@ymita
Copy link

commented Sep 3, 2018

Description

Cell is not editable on iOS

  • igniteui-angular version: 6.1.4
  • browser: Chrome 68.0.3440.83, Safari (iOS 11.4.1(15G77))

Steps to reproduce

  1. Go to https://www.infragistics.com/products/ignite-ui-angular/angular/components/grid_editing.html
  2. Try to edit a cell

Result

The cell does not go into edit mode.

Expected result

The cell goes into edit mode.

@ymita

This comment has been minimized.

Copy link
Author

commented Sep 28, 2018

@zdrawku
Do you assume this issue will take a long time to fix? Or does this look like a straightforward one to fix? I appreciate any information about this issue.

@zdrawku

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2018

@ymita today I will take a closer look and will let you know about all my findings regarding the issue.

@tiliev

This comment has been minimized.

Copy link
Member

commented Oct 10, 2018

This is related to #angular/angular#23954, I pushed a PR. We'll implement a workaround for the time being.

tiliev pushed a commit that referenced this issue Oct 15, 2018

tiliev pushed a commit that referenced this issue Oct 16, 2018

@zdrawku

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2018

@tiliev could you make a PR to 6.2.x branch in order to review and test your implementation. Once the PR is present, change the status of this issue to resolved

@ymita we are goingto assign you as a reviewer as well.

tiliev pushed a commit that referenced this issue Nov 12, 2018

tiliev pushed a commit that referenced this issue Nov 22, 2018

@tiliev tiliev referenced this issue Nov 22, 2018
2 of 14 tasks complete

zdrawku added a commit that referenced this issue Nov 26, 2018

Merge pull request #2988 from IgniteUI/tiliev/ios-double-tap
feat(igxGrid): iOS cell editing support #2538

@rkaraivanov rkaraivanov assigned damyanpetev and rkaraivanov and unassigned tiliev Nov 28, 2018

@rkaraivanov

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

Unfortunately, this PR breaks other of our components which rely on hammerjs events. I'm reopening the issue and we should either extend our kind of forgotten hammer manager class to work with Angular, or hopefully the Angular team will add the doubletap support by default.

@rkaraivanov rkaraivanov reopened this Nov 28, 2018

@pnishimura

This comment has been minimized.

Copy link

commented Jul 1, 2019

Hi @zdrawku, @rkaraivanov @damyanpetev
Out of my curiosity,
Regarding this issue,
Is there no way rather then waiting for the doubletap support by the Angular team?
Or do we have any workaround for it?

@damyanpetev

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

It does seem like this is taking a while to get resolved either by Angular or in iOS (one can dream) so we might as well try to fix it on our own for now.
There's an option to manually attach the double tab to HammerJS though one of our old manager class as @rkaraivanov said.
That'd require a bit refactoring at least. We'll look into it.

@pnishimura

This comment has been minimized.

Copy link

commented Jul 2, 2019

@damyanpetev Thank you for your reply!
Well understood now :)
As you mentioned, originally, this issue should be resolved by Angular or iOS, I think as well.
I'm glad to hear your comment this time.
This issue is not high priority thing,
But It would be great if you guys can let me know if any update around this issue in future.
Thank you again,
Paul

damyanpetev added a commit that referenced this issue Jul 17, 2019

fix(grids): handle double tap to allow editing on iOS #2538
Since iOS WebKit doesn't support dblclick and Angular's Hammer plugin doesn't
have doubletap exposed, resorting to our Hammer manager. Also prevented the
double tap to zoom on the cell as it was rather jarring.

damyanpetev added a commit that referenced this issue Jul 18, 2019

fix(grids): handle double tap to allow editing on iOS #2538
Since iOS WebKit doesn't support dblclick and Angular's Hammer plugin doesn't
have doubletap exposed, resorting to our Hammer manager. Also prevented the
double tap to zoom on the cell as it was rather jarring.

damyanpetev added a commit that referenced this issue Jul 18, 2019

fix(grids): handle double tap to allow editing on iOS #2538
Since iOS WebKit doesn't support dblclick and Angular's Hammer plugin doesn't
have doubletap exposed, resorting to our Hammer manager. Also prevented the
double tap to zoom on the cell as it was rather jarring.

damyanpetev added a commit that referenced this issue Jul 18, 2019

fix(grids): handle double tap to allow editing on iOS #2538
Since iOS WebKit doesn't support dblclick and Angular's Hammer plugin doesn't
have doubletap exposed, resorting to our Hammer manager. Also prevented the
double tap to zoom on the cell as it was rather jarring.

damyanpetev added a commit that referenced this issue Jul 18, 2019

fix(grids): handle double tap to allow editing on iOS #2538
Since iOS WebKit doesn't support dblclick and Angular's Hammer plugin doesn't
have doubletap exposed, resorting to our Hammer manager. Also prevented the
double tap to zoom on the cell as it was rather jarring.

Lipata added a commit that referenced this issue Aug 5, 2019

Merge pull request #5461 from IgniteUI/dpetev/ios-grid-edit-7-2
fix(grids): handle double tap to allow editing on iOS #2538

Lipata added a commit that referenced this issue Aug 5, 2019

Merge pull request #5462 from IgniteUI/dpetev/ios-grid-edit-7-3
fix(grids): handle double tap to allow editing on iOS #2538

Lipata added a commit that referenced this issue Aug 5, 2019

Merge pull request #5463 from IgniteUI/dpetev/ios-grid-edit-8-0
fix(grids): handle double tap to allow editing on iOS #2538

Lipata added a commit that referenced this issue Aug 5, 2019

Merge pull request #5464 from IgniteUI/dpetev/ios-grid-edit-8-1
fix(grids): handle double tap to allow editing on iOS #2538

@kdinev kdinev closed this in #5542 Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.