Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required date picker bound to displayData is shown invalid initially. #3641

Closed
gedinakova opened this issue Jan 17, 2019 · 0 comments · Fixed by #3650, #3765 or #3861
Closed

Required date picker bound to displayData is shown invalid initially. #3641

gedinakova opened this issue Jan 17, 2019 · 0 comments · Fixed by #3650, #3765 or #3861
Assignees
@gedinakova
Labels
🐛 bug Any issue that describes a bug 📅 date-picker 🧨 severity: medium version: 7.1.x version: 7.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@gedinakova
Copy link
Contributor

Description

Required date picker is shown with the invalid style applied even before being touched when the input is bound to displayData instead of value.

  • igniteui-angular version: 7.1.x, 7.2.x
  • browser: N/A

Steps to reproduce

  1. Run https://stackblitz.com/edit/datepickerdemo-issue
  2. Note the two date pickers

Result

End date is shown invalid while Start date is not.

Expected result

End date should not be marked invalid.
@gedinakova gedinakova self-assigned this Jan 17, 2019
@gedinakova gedinakova added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jan 17, 2019
gedinakova added a commit that referenced this issue Jan 17, 2019
@gedinakova
fix(DatePicker): #3641 Required inputs shouldn't be validated initially.
8ec0136
@gedinakova gedinakova mentioned this issue Jan 17, 2019
Merged
14 tasks
gedinakova added a commit that referenced this issue Jan 17, 2019
@gedinakova
fix(DatePicker): #3641 Required inputs shouldn't be validated initially.
8f1c1bb
gedinakova added a commit that referenced this issue Jan 17, 2019
@gedinakova
fix(DatePicker): #3641 Required inputs shouldn't be validated initially.
6be30d0
gedinakova added a commit that referenced this issue Jan 17, 2019
@gedinakova
fix(DatePicker): #3641 Required inputs shouldn't be validated initially.
6d6964b
@gedinakova gedinakova mentioned this issue Jan 17, 2019
Merged
14 tasks
@gedinakova gedinakova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jan 17, 2019
kdinev added a commit that referenced this issue Jan 18, 2019
@kdinev
Merge pull request #3650 from IgniteUI/gedinakova/date-picker-master
34fc2ab 
#3641 Required inputs shouldn't be validated initially.
gedinakova added a commit that referenced this issue Jan 29, 2019
@gedinakova
fix(Input): #3641 Don't mark not forms control invalid initially.
3df44c9
gedinakova added a commit that referenced this issue Jan 29, 2019
@gedinakova
fix(Input): #3641 Don't mark not forms control invalid initially.
7d7cc7c
@gedinakova gedinakova mentioned this issue Jan 30, 2019
Merged
10 tasks
gedinakova added a commit that referenced this issue Feb 1, 2019
@gedinakova
fix(Input): #3641 Don't mark not forms control invalid initially. (#3765
1abe0f0 
)
rkaraivanov added a commit that referenced this issue Feb 1, 2019
@rkaraivanov
Merge pull request #3648 from IgniteUI/gedinakova/date-picker-7.1.x
6e7b538 
#3641 Required inputs shouldn't be validated initially.
gedinakova added a commit that referenced this issue Feb 7, 2019
@gedinakova
fix(Input): #3641 Remove the '' from input value setter.
669d8be
@gedinakova gedinakova mentioned this issue Feb 7, 2019
Merged
14 tasks
gedinakova added a commit that referenced this issue Feb 7, 2019
@gedinakova
fix(Input): #3641 Remove the '' from input value setter.
c7cdbc3
@gedinakova gedinakova mentioned this issue Feb 7, 2019
Merged
14 tasks
gedinakova added a commit that referenced this issue Feb 18, 2019
@gedinakova
fix(Input): #3641 Remove the '' from input value setter. (#3860)
c014ca9
kdinev added a commit that referenced this issue Feb 19, 2019
@kdinev
Merge pull request #3861 from IgniteUI/gedinakova/fix-input-value-master
939c7c7 
fix(Input): #3641 Remove the '' from input value setter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gedinakova gedinakova

Labels
🐛 bug Any issue that describes a bug 📅 date-picker 🧨 severity: medium version: 7.1.x version: 7.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
1 participant
@gedinakova