Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IgxToggleAction logs deprecated message in the console #4126

Closed
wnvko opened this issue Mar 1, 2019 · 0 comments · Fixed by #4138
Closed

IgxToggleAction logs deprecated message in the console #4126

wnvko opened this issue Mar 1, 2019 · 0 comments · Fixed by #4138
Assignees
@wnvko
Labels
🐛 bug Any issue that describes a bug severity: low toggle version: 7.1.8 ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
19.1 Sprint 29

Comments

@wnvko
Copy link
Contributor

wnvko commented Mar 1, 2019

Description

When IgxToggleAction is added on an element when the element gets clicked this message logs in the console:

"IgxToggleActionDirective.closeOnOutsideClick: igxToggleAction 'closeOnOutsideClick' input is deprecated. Use 'overlaySettings' input object instead"

  • igniteui-angular version: 7.1.8
  • browser: all

Steps to reproduce

  1. Open this sample;
  2. Click on the input to toggle drop down;
  3. Observe the console;

Result

"IgxToggleActionDirective.closeOnOutsideClick: igxToggleAction 'closeOnOutsideClick' input is deprecated. Use 'overlaySettings' input object instead" is logged in the console

Expected result

No deprecation messages should log in the console.
@wnvko wnvko self-assigned this Mar 1, 2019
@wnvko wnvko added this to To do in 19.1 Sprint 29 via automation Mar 1, 2019
@wnvko wnvko added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Mar 1, 2019
@wnvko wnvko moved this from To do to In progress in 19.1 Sprint 29 Mar 1, 2019
wnvko added a commit that referenced this issue Mar 1, 2019
@wnvko
fix(igxToggleAction): remove calls to closeOnOutsideClick property, #…
289fcb4 
…4126
wnvko added a commit that referenced this issue Mar 1, 2019
@wnvko
fix(igxToggleAction): remove calls to closeOnOutsideClick property, #…
19cd230 
…4126
This was referenced Mar 1, 2019
Merged
Merged
@wnvko wnvko added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Mar 1, 2019
19.1 Sprint 29 automation moved this from In progress to Done Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wnvko wnvko

Labels
🐛 bug Any issue that describes a bug severity: low toggle version: 7.1.8 ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
No open projects
19.1 Sprint 29
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove calls to closeOnOutsideClick property IgniteUI/igniteui-angular
1 participant
@wnvko