Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove calls to closeOnOutsideClick property #4137

Merged
merged 1 commit into from Mar 1, 2019
Merged

Remove calls to closeOnOutsideClick property #4137

merged 1 commit into from Mar 1, 2019

Conversation

wnvko
Copy link
Contributor

@wnvko wnvko commented Mar 1, 2019

In onClick handler we were calling deprecated closeOnOutsideClick property. This was logging a deprecation message. Now we are calling directly the inner field and bypassing the property.

Closes #4126

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@wnvko wnvko added ❌ status: awaiting-test PRs awaiting manual verification toggle version: 7.1.x labels Mar 1, 2019
@ViktorSlavov ViktorSlavov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Mar 1, 2019
@ViktorSlavov ViktorSlavov self-assigned this Mar 1, 2019
@ViktorSlavov ViktorSlavov added ✅ status: verified Applies to PRs that have passed manual verification version: 7.1.x and removed 💥 status: in-test PRs currently being tested version: 7.1.x labels Mar 1, 2019
@kdinev kdinev merged commit c1d8f58 into 7.1.x Mar 1, 2019
@kdinev kdinev deleted the mvenkov/remove-deprecation-warning-7.1.x branch March 1, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdinev kdinev kdinev approved these changes

@PlamenaMiteva PlamenaMiteva PlamenaMiteva approved these changes

@bazal4o bazal4o Awaiting requested review from bazal4o

Assignees

@ViktorSlavov ViktorSlavov

Labels
toggle version: 7.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wnvko @kdinev @PlamenaMiteva @ViktorSlavov