Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When transactions are enabled and update a filtered cell there is an error in console #4214

Closed
nrobakova opened this issue Mar 7, 2019 · 0 comments
Closed

When transactions are enabled and update a filtered cell there is an error in console #4214

nrobakova opened this issue Mar 7, 2019 · 0 comments
Assignees
@ddincheva
Labels
batch-editing 🐛 bug Any issue that describes a bug 🧨 severity: medium grid: cell-editing grid: general version: 7.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@nrobakova
Copy link
Contributor

Description

When transactions are enabled and update a filtered cell there is an error in console

  • igniteui-angular version: 7.2
  • browser: N/A

Steps to reproduce

  1. Open dev sample treeGrid
  2. Filter column ConatactName
  3. Open filtered cell in edit mode and change its value
  4. Press enter button

Result

An error in console is previewed:
IgxTreeGridRowComponent.html:19 ERROR Error: ViewDestroyedError: Attempt to use a destroyed view: detectChanges
at viewDestroyedError (core.js:20354)
at Object.debugUpdateDirectives [as updateDirectives] (core.js:23810)
at checkAndUpdateView (core.js:23209)
at callWithDebugContext (core.js:24079)
at Object.debugCheckAndUpdateView [as checkAndUpdateView] (core.js:23781)
at ViewRef_.push../node_modules/@angular/core/fesm5/core.js.ViewRef_.detectChanges (core.js:21590)
at IgxGridCellComponent.set [as inEditMode] (cell.component.ts:295)
at IgxGridCellComponent.push../projects/igniteui-angular/src/lib/grids/cell.component.ts.IgxGridCellComponent.onKeydownEnterEditMode (cell.component.ts:845)
at IgxGridCellComponent.push../projects/igniteui-angular/src/lib/grids/cell.component.ts.IgxGridCellComponent.dispatchEvent (cell.component.ts:820)

Expected result

There should be no errors

Attachments

Attach a sample if available, and screenshots, if applicable.
@ddincheva ddincheva added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Mar 8, 2019
ddincheva added a commit that referenced this issue Mar 15, 2019
@ddincheva
test(IgxSummary): recalc summaries on filtering and update cell #4214
4391bd1
ddincheva added a commit that referenced this issue Mar 27, 2019
@ddincheva
fix(IgxCell): check if cell still match filter criteria after update #…
e0871ab 
…4214
@ddincheva ddincheva mentioned this issue Mar 27, 2019
Merged
14 tasks
@ddincheva ddincheva added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Mar 27, 2019
ddincheva added a commit that referenced this issue Mar 27, 2019
@ddincheva
fix(IgxCell): check if cell still match filter criteria after update #…
c6933e6 
…4214
@ddincheva ddincheva mentioned this issue Mar 27, 2019
Merged
14 tasks
ddincheva added a commit that referenced this issue Mar 28, 2019
@ddincheva
fix(IgxCell): remove unnecessary changeDetection on exit editMode #4214
220f9ba
ddincheva added a commit that referenced this issue Mar 28, 2019
@ddincheva
fix(IgxCell): remove unnecessary changeDetection on exit editMode #4214
3adb964
@kdinev kdinev mentioned this issue Mar 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddincheva ddincheva

Labels
batch-editing 🐛 bug Any issue that describes a bug 🧨 severity: medium grid: cell-editing grid: general version: 7.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nrobakova @ddincheva