Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong endEdit call on data operation pipes subscribe #4313

Closed
zdrawku opened this issue Mar 13, 2019 · 0 comments · Fixed by #4615
Closed

Wrong endEdit call on data operation pipes subscribe #4313

zdrawku opened this issue Mar 13, 2019 · 0 comments · Fixed by #4615
Assignees
Labels
batch-editing 🐛 bug Any issue that describes a bug 🧨 severity: medium grid: cell-editing grid: general grid: row-editing version: 7.2.0 ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@zdrawku
Copy link
Contributor

zdrawku commented Mar 13, 2019

Description

endEdit is called on sort() and on onSortingDone pipe subscribe with different parameters.

According to Grid editing wiki, on filtering and sorting Grid will endEdit without commit of the changes, although endEdit is with true parameter, which means commit the changes, and this is a bit inconsistent.

Snippet:

this.onFilteringDone.pipe(takeUntil(this.destroy$)).subscribe(() => this.endEdit(true));
..
this.onSortingDone.pipe(takeUntil(this.destroy$)).subscribe(() => this.endEdit(true));

Related to #2900

@nrobakova nrobakova added the 🛠️ status: in-development Issues and PRs with active development on them label Apr 19, 2019
@nrobakova nrobakova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-editing 🐛 bug Any issue that describes a bug 🧨 severity: medium grid: cell-editing grid: general grid: row-editing version: 7.2.0 ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants