Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rowEditing] IgxTreeGrid row editing overlay buttons cannot be properly templated #5431

Closed
ViktorSlavov opened this issue Jul 16, 2019 · 0 comments · Fixed by #5436
Closed

[rowEditing] IgxTreeGrid row editing overlay buttons cannot be properly templated #5431

ViktorSlavov opened this issue Jul 16, 2019 · 0 comments · Fixed by #5436
Assignees
@Lipata @ViktorSlavov
Labels
🐛 bug Any issue that describes a bug 🧨 severity: medium grid: row-editing grid: tree-grid ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@ViktorSlavov
Copy link
Contributor

Description

The IgxTreeGrid component template does not properly account for passed custom buttons and text for the Row Editing overlay

  • igniteui-angular version: 7.3.x, 8.0.x, 8.1.x
  • browser: N/A

Steps to reproduce

  1. Open the following StackBlitz
  2. Review the component template
  3. Open row editing on any row

Result

The row editing overlay is not properly templated

Expected result

The row editing overlay is properly templated
@ViktorSlavov ViktorSlavov added 🐛 bug Any issue that describes a bug 🛠️ status: in-development Issues and PRs with active development on them 🧨 severity: medium grid: tree-grid grid: row-editing labels Jul 16, 2019
ViktorSlavov added a commit that referenced this issue Jul 16, 2019
@ViktorSlavov
fix(tree-grid): update tree-grid template to allow custom row-edit, #…
71f0f57 
…5431
ViktorSlavov added a commit that referenced this issue Jul 16, 2019
@ViktorSlavov
fix(tree-grid): update tree-grid template to allow custom row-edit, #…
0e830de 
…5431
ViktorSlavov added a commit that referenced this issue Jul 16, 2019
@ViktorSlavov
fix(tree-grid): update tree-grid template to allow custom row-edit, #…
a87bb98 
…5431
This was referenced Jul 16, 2019
Merged
Merged
Merged
@ViktorSlavov ViktorSlavov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jul 16, 2019
@ViktorSlavov ViktorSlavov mentioned this issue Jul 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lipata Lipata

@ViktorSlavov ViktorSlavov

Labels
🐛 bug Any issue that describes a bug 🧨 severity: medium grid: row-editing grid: tree-grid ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
2 participants
@Lipata @ViktorSlavov