Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 - IgxDialog jumps! #5576

Closed
luiscla27 opened this issue Aug 2, 2019 · 2 comments · Fixed by #5662
Closed

IE11 - IgxDialog jumps! #5576

luiscla27 opened this issue Aug 2, 2019 · 2 comments · Fixed by #5662
Assignees
Labels
🐛 bug Any issue that describes a bug dialog 🧨 severity: medium 🆕 status: new version: 7.3.x version: 8.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@luiscla27
Copy link

Description

IgxDialog appears at the bottom screen and then "jumps" to the center

  • igniteui-angular version: 8.1.0 and 7.3.3
  • browser: IE11

Steps to reproduce

  1. Open your demo page from IE11
  2. https://www.infragistics.com/products/ignite-ui-angular/angular/components/dialog.html
  3. Click the "Show dialog" of the "Dialog demo sample"

Result

The dialog will show at the bottom of the IFRAME and then it'll move to the center of it.

Expected result

Either one of the following would be ok.

  1. Show the dialog at the center of the screen from the very begining.
  2. Fix the "fadding" animation so the movement doesn't look like a "jump"

If you have a workaround to just "disable" the animation that'll be ok for me :)

Attachments

Video_2019-08-02_175052

@luiscla27 luiscla27 added the 🐛 bug Any issue that describes a bug label Aug 2, 2019
@luiscla27
Copy link
Author

luiscla27 commented Aug 2, 2019

This is the current workaround am using, wich i think is really really ugly, i'll greatly appreciate a better approach:

/* IE10 & 11 Only - Small resolution*/
@media screen and (-ms-high-contrast: active), (-ms-high-contrast: none) {
  .igx-dialog__window {
    position: fixed!important;
    top: 0px!important;
    overflow: hidden!important;
    margin: 0;
    left: 0;
    right: 0;
  }
}
/* IE10 & 11 Only - Medium resolution */
@media screen and (min-width: 40em) and (-ms-high-contrast: active) {
  .igx-dialog__window {
    top: 25%!important;
    margin: auto 32%;
  }
}

@zdrawku zdrawku self-assigned this Aug 5, 2019
@zdrawku
Copy link
Contributor

zdrawku commented Aug 5, 2019

Hey @luiscla27, we should expose animationSettings @input for the Dialog as we did for the Banner component, I confirm this is behavior which cannot be configured by the end-user right now, and I am adding status "In Review"

As for the animations, these are the default animations that we've created for the Dialog component: openAnimation is slideInBottom and closeAnimation is slideOutTop.

zdrawku added a commit that referenced this issue Aug 19, 2019
zdrawku added a commit that referenced this issue Aug 19, 2019
@zdrawku zdrawku added the ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. label Aug 19, 2019
zdrawku added a commit that referenced this issue Aug 19, 2019
zdrawku added a commit that referenced this issue Aug 19, 2019
zdrawku added a commit that referenced this issue Aug 19, 2019
zdrawku added a commit that referenced this issue Aug 19, 2019
zdrawku added a commit that referenced this issue Aug 19, 2019
zdrawku added a commit that referenced this issue Aug 19, 2019
zdrawku added a commit that referenced this issue Aug 19, 2019
zdrawku added a commit that referenced this issue Aug 19, 2019
zdrawku added a commit that referenced this issue Aug 19, 2019
zdrawku added a commit that referenced this issue Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug dialog 🧨 severity: medium 🆕 status: new version: 7.3.x version: 8.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants