Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: Add position settings input #5660

Merged
merged 6 commits into from Aug 19, 2019
Merged

Dialog: Add position settings input #5660

merged 6 commits into from Aug 19, 2019

Conversation

zdrawku
Copy link
Contributor

@zdrawku zdrawku commented Aug 19, 2019 •
edited

Closes #5576

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@zdrawku zdrawku requested a review from nrobakova August 19, 2019 12:54
@zdrawku zdrawku changed the title Zkolev/add animation settings input 73x Dialog: Add position settings input Aug 19, 2019
@nrobakova nrobakova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Aug 19, 2019
@nrobakova nrobakova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Aug 19, 2019
@zdrawku zdrawku merged commit b00b95f into 7.3.x Aug 19, 2019
@zdrawku zdrawku deleted the zkolev/add-animation-settings-input-73x branch August 19, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrobakova nrobakova nrobakova approved these changes

Assignees

@nrobakova nrobakova

Labels
dialog version: 7.3.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zdrawku @nrobakova