Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excel style filtering sample - not visualized correctly #6815

Closed
DaniMarinov opened this issue Feb 25, 2020 · 3 comments · Fixed by #7596
Closed

Excel style filtering sample - not visualized correctly #6815

DaniMarinov opened this issue Feb 25, 2020 · 3 comments · Fixed by #7596
Assignees
@onlyexeption @DiyanDimitrov @radomirchev
Labels
🐛 bug Any issue that describes a bug grid: excel-style-filtering version: 9.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
15-June-20 M12 Sprint 1

Comments

@DaniMarinov
Copy link

DaniMarinov commented Feb 25, 2020 •
edited

Description

Here https://www.infragistics.com/products/ignite-ui-angular/angular/components/grid/excel_style_filtering.html#configure-menu-features
on the second sample, the ESF is not visualized correctly

Steps to reproduce

  1. Go to https://www.infragistics.com/products/ignite-ui-angular/angular/components/grid/excel_style_filtering.html#configure-menu-features
  2. Scroll to the ESF sample above
  3. Check all ESF for all columns

Result

Screen Shot 2020-02-25 at 11 56 59 AM
@github-actions
Copy link

github-actions bot commented May 8, 2020

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label May 8, 2020
@DiyanDimitrov DiyanDimitrov reopened this May 15, 2020
@DiyanDimitrov DiyanDimitrov reopened this May 23, 2020
@DiyanDimitrov DiyanDimitrov removed the status: inactive Used to stale issues and pull requests label May 26, 2020
@DiyanDimitrov
Copy link
Contributor

@DaniMarinov @StefanIvanov, could you guys propose a new design for this sample? The idea is to demonstrate the option to re-template the ESF parts. One of the most common usage of this re-templating is to hide the non-filtering options from the ESF so maybe such sample would be appropriate.

@DaniMarinov
Copy link
Author

DaniMarinov commented Jun 3, 2020 •
edited

@DiyanDimitrov My suggestion is just to left-align the text and to change it to more meaningful label, such as"Template area [Sorting]", for example.

@onlyexeption onlyexeption added the 🛠️ status: in-development Issues and PRs with active development on them label Jun 9, 2020
onlyexeption added a commit that referenced this issue Jun 9, 2020
@onlyexeption
fix(excel-style-filtering): fixed template visualization #6815
f4fa687
@onlyexeption onlyexeption mentioned this issue Jun 9, 2020
Merged
14 tasks
onlyexeption added a commit that referenced this issue Jun 9, 2020
@onlyexeption
chore(*): fix lint errors #6815
1cf5fcd
onlyexeption added a commit that referenced this issue Jun 10, 2020
@onlyexeption
chore(*): remove padding for cosy and compact #6815
d1c0b49
@onlyexeption onlyexeption added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jun 10, 2020
onlyexeption added a commit that referenced this issue Jun 10, 2020
@onlyexeption
fix(escel-style-filtering): fixed template visualization #6815
c9b2b31
@onlyexeption onlyexeption mentioned this issue Jun 10, 2020
Merged
14 tasks
onlyexeption added a commit that referenced this issue Jun 10, 2020
@onlyexeption
chore(*): add padding only for top and bottom #6815
2ca843d
onlyexeption added a commit that referenced this issue Jun 10, 2020
@onlyexeption
chore(*): add padding only for top and bottom #6815
238d308
kdinev added a commit that referenced this issue Jun 15, 2020
@kdinev
Merge pull request #7544 from IgniteUI/ibarakov/fix-6815-9.1.x
ca88126 
Fixed template visualization #6815
@kdinev kdinev mentioned this issue Jun 15, 2020
Merged
rkaraivanov pushed a commit that referenced this issue Jun 16, 2020
@onlyexeption @simeonoff
Fixed template visualization #6815 (#7520)
a19dc03 
* fix(excel-style-filtering): fixed template visualization #6815

Co-authored-by: Simeon Simeonoff <sim.simeonoff@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onlyexeption onlyexeption

@DiyanDimitrov DiyanDimitrov

@radomirchev radomirchev

Labels
🐛 bug Any issue that describes a bug grid: excel-style-filtering version: 9.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
No open projects
15-June-20 M12 Sprint 1
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merging 9.1.x into master IgniteUI/igniteui-angular
4 participants
@onlyexeption @DaniMarinov @DiyanDimitrov @radomirchev