Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed template visualization #6815 #7520

Merged
merged 5 commits into from
Jun 16, 2020
Merged

Fixed template visualization #6815 #7520

merged 5 commits into from
Jun 16, 2020

Conversation

onlyexeption
Copy link
Contributor

Closes #6815

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff added ❌ status: not-fixed and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 9, 2020
simeonoff
simeonoff requested changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove the left and right padding from cosy and compact as well.

@DiyanDimitrov DiyanDimitrov added ❌ status: awaiting-test PRs awaiting manual verification and removed ❌ status: not-fixed labels Jun 10, 2020
@simeonoff simeonoff added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 15, 2020
@simeonoff simeonoff added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jun 15, 2020
@rkaraivanov rkaraivanov merged commit a19dc03 into 9.0.x Jun 16, 2020
@rkaraivanov rkaraivanov deleted the ibarakov/fix-6815-9.0.x branch June 16, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff simeonoff approved these changes

@DiyanDimitrov DiyanDimitrov DiyanDimitrov approved these changes

Assignees
No one assigned
Labels
grid: excel-style-filtering version: 9.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@onlyexeption @simeonoff @DiyanDimitrov @rkaraivanov