Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BottomNav integration with router outlet is not considering guards and updates UI incorrectly #7009

Closed
DiyanDimitrov opened this issue Mar 30, 2020 · 0 comments · Fixed by #7094
Closed

BottomNav integration with router outlet is not considering guards and updates UI incorrectly #7009

DiyanDimitrov opened this issue Mar 30, 2020 · 0 comments · Fixed by #7094
Assignees
@DiyanDimitrov @igdmdimitrov
Labels
bottom-nav Bottom navigation component 🐛 bug Any issue that describes a bug 🧨 severity: medium version: 8.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@DiyanDimitrov
Copy link
Contributor

Description

When using guards (canActivate or canDeactivate), the bottom nav updates the UI according to which tab(url) the user clicked even though the guard blocked that path.

NOTE: This scenario is already fixed for igx-tabs component #6845.

  • igniteui-angular version: 8.2.x
  • browser: NA

Steps to reproduce

  1. Open https://stackblitz.com/edit/angular-whxt3t-azcq3u
  2. Click on "Canceled" tab (this url is blocked by a canActivate guard)

Result

The UI is highlighted on the "Canceled" tab, but the view does not show its contents

Expected result

Since the url is blocked by the guard, the UI tab should be updated to the current url.
@DiyanDimitrov DiyanDimitrov added 🐛 bug Any issue that describes a bug bottom-nav Bottom navigation component 🆕 status: new 🧨 severity: medium version: 8.2.x labels Mar 30, 2020
@DiyanDimitrov DiyanDimitrov added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Apr 7, 2020
igdmdimitrov added a commit that referenced this issue Apr 9, 2020
@igdmdimitrov
fix(bottom-nav): fixes on routing and tab related attributes #7009
ec23d84
@igdmdimitrov igdmdimitrov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Apr 9, 2020
@igdmdimitrov igdmdimitrov mentioned this issue Apr 9, 2020
Merged
14 tasks
igdmdimitrov added a commit that referenced this issue Apr 13, 2020
@igdmdimitrov
fix(bottom-nav): fixes on routing and tab related attributes #7009
bf5dc20
@igdmdimitrov igdmdimitrov mentioned this issue Apr 13, 2020
Merged
14 tasks
igdmdimitrov added a commit that referenced this issue Apr 13, 2020
@igdmdimitrov
fix(bottom-nav): fixes on routing and tab related attributes #7009
8e7dcc3
@igdmdimitrov igdmdimitrov mentioned this issue Apr 13, 2020
Merged
14 tasks
igdmdimitrov added a commit that referenced this issue Apr 13, 2020
@igdmdimitrov
chore(*): fix build #7009
d97ab18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiyanDimitrov DiyanDimitrov

@igdmdimitrov igdmdimitrov

Labels
bottom-nav Bottom navigation component 🐛 bug Any issue that describes a bug 🧨 severity: medium version: 8.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(bottom-nav): fixes on routing and tab related attributes IgniteUI/igniteui-angular
2 participants
@DiyanDimitrov @igdmdimitrov