Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IgniteUI.Blazor.Documents.Excel.Trial references IgniteUI.Blazor.Documents.Core #329

Open
kdinev opened this issue Apr 3, 2023 · 11 comments · May be fixed by #313
Open

IgniteUI.Blazor.Documents.Excel.Trial references IgniteUI.Blazor.Documents.Core #329

kdinev opened this issue Apr 3, 2023 · 11 comments · May be fixed by #313
Assignees
Labels
bug: in-product issues caused by IG product severity: high

Comments

@kdinev
Copy link
Member

kdinev commented Apr 3, 2023

There's a non-trial reference as a dependency to a trial package.

image

image

@kdinev kdinev linked a pull request Apr 3, 2023 that will close this issue
@kdinev kdinev added the bug: in-product issues caused by IG product label Apr 3, 2023
@igandrews
Copy link

Looks like the trial package creation just sets an msbuild property that is used to affect the PackageId but there must be a bug in the sdk pack handling whereby when it creates the nuspec and gather's the package names for the project references they must just read the PackageId from the csproj file without considering the current properties.

@kdinev
Copy link
Member Author

kdinev commented Apr 12, 2023

@igandrews @gmurray81 Who can push a fixed Trial package, so we can get the examples project building?

@igandrews
Copy link

I’ll look to update the build script today. Since it doesn’t look like this was something recently broken I didn’t rush into this.

@kdinev
Copy link
Member Author

kdinev commented Apr 12, 2023

Thank you @igandrews! These packages are relatively new, but if anyone tries to use them, they simply won't work. We are also setting up GH actions CI for this repository and the task is blocked by the Trial packages.

@mddragnev
Copy link
Member

I came across this yesterday too. Took me a solid hour to figure it out and fix it locally by myself. If anyone runs across this issue - a simple fix is to add the local proget to the nuget resources of the solution.

@gmurray81
Copy link
Member

I believe this is fixed in the build BTW, we just need to produce a new set of packages after fixing a last build problem.

@kdinev
Copy link
Member Author

kdinev commented May 2, 2023

@gmurray81 Is there an ETA on the new trial packages?

@kdinev
Copy link
Member Author

kdinev commented May 22, 2023

Bump.

@gmurray81
Copy link
Member

@kdinev this and NG 16 are just waiting on some of the release scripts coming back online in devops. Brian was working on this, will check how its going in our git scrum this morning.

@gmurray81
Copy link
Member

also I think we were investigating a regression still.

@gmurray81
Copy link
Member

BTW, these scripts are migrated apparently, but untested until we try to push. Still waiting on that regression to be investigated first, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: in-product issues caused by IG product severity: high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants