added HEIF writer and replaced HEIF reader with a more complete HEIF implementation #1099

farindk · 2018-04-17T15:00:40Z

Added code for writing HEIF files based on libheif.
https://github.com/strukturag/libheif
There is a Debian package for libheif, but you will need the latest git version for the encoder (will be released soon).

I also replaced the HEIF reader with the implementation from libheif as the old implementation was limited to only reading HEIF files generated by iPhones. The new implementation is a full implementation of the HEIF standard (still image part) including all image compositing operations.

Alpha channel support is in libheif, but not yet implemented here, since I could not figure out yet how to implement this in ImageMagick.

…on libheif instead

dlemstra · 2018-04-17T15:24:03Z

Thanks for the PR 👍 Happy to see we get write support. I was wonder if it would be possible to do also add something for when we only want to ping (get basic image information) the image. Now the whole file is loaded into memory and I was wondering if we could load only part of the image when we want to ping it.

farindk · 2018-04-17T15:55:20Z

Oh, that's what the 'ping' flag is for. I was wondering about that already but could not find out the purpose of that flag. I am a complete beginner to the ImageMagick code, so I do not know yet: - whether I am doing things right for "lists of images" - how to handle alpha channels - what I should do when the HEIF contains several images (libheif supports that) - the iPhone also saves "depth images" into the HEIF as an auxiliary image. How could I pass them to ImageMagick? - could I pass more options to the HEIF encoder, like whether it should generate thumbnails, or whether to switch to lossless mode? Any pointers to information would be appreciated. Especially alpha channels would be nice, I think. Dirk 2018-04-17 17:24 GMT+02:00 Dirk Lemstra <notifications@github.com>:

…

Thanks for the PR 👍 Happy to see we get write support. I was wonder if it would be possible to do also add something for when we only want to ping (get basic image information) the image. Now the whole file is loaded into memory and I was wondering if we could load only part of the image when we want to ping it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1099 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA7I8E9CSeL0Go__pbJ-KwREnDFSC4S2ks5tpgkfgaJpZM4TYfY1> .

farindk · 2018-04-17T16:12:24Z

Here is support for the 'ping' flag. Hope I did it right.

dbtsai · 2018-04-17T17:51:45Z

Thanks for this PR. This is a great feature supporting HEIF write.

dlemstra · 2018-04-17T20:23:48Z

When will the encoder be released? I think it will be wise to wait till that is available before we merge this. I would prefer it if our users would not need to compile the latest git checkout of libheif to get heif support.

whether I am doing things right for "lists of images"

LGTM

how to handle alpha channels

You can use SetPixelAlpha to set the alpha channel.

what I should do when the HEIF contains several images (libheif supports that)

You can take a look at an other decoder that also reads multiple frames and look how AcquireNextImage is used.

the iPhone also saves "depth images" into the HEIF as an auxiliary image. How could I pass them to ImageMagick?

What are depth images and how could we use them?

could I pass more options to the HEIF encoder, like whether it should generate thumbnails, or whether to switch to lossless mode?

You will need to create options that start with heic: for example heic:lossless and check them in the encoder or decoder where you need those options. You can take a look at the other coders to see how we do that.

Prob best to put these extra changes in a separate PR after we merge this one.

dlemstra · 2018-04-18T10:10:33Z

coders/heic.c

      goto error_cleanup;
    }

+
+    if (image->quality != UndefinedCompressionQuality) {


You should use image_info->quality instead.

Provides optional HEIF support. Note the upstream PR here, which may change things in the future in terms of how this option needs handling: ImageMagick/ImageMagick#1099 Fixes #26444. Closes #26959. Signed-off-by: ilovezfs <ilovezfs@icloud.com>

farindk · 2018-04-25T08:27:20Z

The libheif package with encoder (v1.1.0) is now in debian testing: https://tracker.debian.org/pkg/libheif
It is also in Ubuntu 18.04.

dlemstra · 2018-04-25T08:34:05Z

@farindk Thats great news!!! 🙌 👍 Could you resolve the conflicts in this branch so I can merge this Friday? We will run autoconf ourselves so maybe you could exclude some of your changes.

… master branch

dlemstra · 2018-04-26T20:37:28Z

@farindk It looks like we need to use x265 to get encoding support? That won't be an option for us since that is licensed under the GPL v2 license. We could still use the libheif library if that means we would get better support for reading files. Can you remove the writer for now?

EDIT: I can also merge as is and remove the writer myself. Whats your preference?

farindk · 2018-04-26T21:42:42Z

I was not aware that the ImageMagick license does not allow any GPL v2 libraries, as the ImageMagick license page says that it is compatible to GPL v3. It is because of v2/v3 or because of linking against GPL in general?

How about this solution: I could change the encoding code in libheif in such a way that it does not link to libx265 at all, but uses the separate "x265" program for encoding, passing the data through a pipe. That way, libheif would be LGPL, if I am correct.
In the long term, my plan is to use libde265 itself for encoding instead of x265, but the encoding API is not ready yet.

EDIT: isn't libfftw also GPL?

dlemstra · 2018-04-26T22:11:02Z

We try to avoid linking against GPL libraries. If we also want to get this building under Windows that would mean we would also need to build the x265 library. But I don't want to invest any time in getting that building on Windows due to the license that is being used. The MAGICKCORE_HEIC_DELEGATE define is for both the reader and the writer.

While writing the message I just got another idea. I could disable writing with the MAGICKCORE_WINDOWS_SUPPORT define under Windows and still enable support for writing under other platforms. I am still that your long term plan is getting rid of the x265 dependency. But aren't you forced to use GPL instead of LGPL for the encoder because you are using x265?

farindk · 2018-04-26T22:30:29Z

Disabling it only for Windows sounds like a good solution to me. Then we can easily enable it later when the dependency is removed.

libheif does not require linking to x265. One can register any number of encoding plugins even during runtime. x265 is only one option that is provided by default. But one can also add encoders for AV1, h264, or JPEG. If libx265 is not detected during configuration, that plugin is switched off. In that sense libheif itself is LGPL, but when used together with x265, the combination is GPL.

dbtsai · 2018-08-16T20:46:06Z

@farindk

I'm using

# convert --version
Version: ImageMagick 7.0.8-10 Q16 x86_64 2018-08-15 https://www.imagemagick.org
Copyright: © 1999-2018 ImageMagick Studio LLC
License: https://www.imagemagick.org/script/license.php
Features: Cipher DPC HDRI Modules 
Delegates (built-in): bzlib freetype heic jng jpeg ltdl lzma png tiff xml zlib

with heic support.

When I converted TIFF files with AdobeRGB profile to HEIC files, the color will be changed. convert DSC01108.tif DSC01108.heic

Seems the color profile is not properly copied to the new HEIC files. Also, the input file has Colorspace RGB while the output HEIC one is YCbCr. Is it possible to keep as it? How do I specify the compression rate and using 12bit color depth?

Thanks.

farindk · 2018-08-17T11:28:38Z

Support for color profiles was just added to libheif (strukturag/libheif#58), but it still needs to be integrated to ImageMagick.

RGB colorspace and HDR is on my to-do list. See also strukturag/libheif#62.

dbtsai · 2018-08-17T15:16:19Z

Thanks, @farindk ! I also ran into lossless mode issue.

FYI, I found compare will give huge error due to comparing image in YCbCr and RGB directly without converting YCbCr to RGB.

farindk added 7 commits April 16, 2018 18:11

first implementation of HEIC writer based on libheif

4de43e7

new HEIC reader based on libheif

1adc930

rename HEIC image type

0273882

adapt to changed encoder API

18a90ca

read Exif data from HEIC

668bcd9

remove check for libde265 from autoconf as we are now depending only …

c944627

…on libheif instead

check in autoconf files (note: these should not be in git)

542c401

farindk mentioned this pull request Apr 17, 2018

encode to HEIF #997

Closed

farindk mentioned this pull request Apr 17, 2018

Any plan to support Main 4:4:4 16 bits strukturag/libde265#162

Open

support 'ping' for reading image attributes without decoding

465f3c2

farindk added 2 commits April 18, 2018 11:40

variable HEIF compression quality setting

ecb11c0

show proper error messages

1fe2f29

dlemstra reviewed Apr 18, 2018

View reviewed changes

use image_info->quality instead of image->quality

cb17ad8

DomT4 mentioned this pull request Apr 23, 2018

imagemagick: add optional HEIF support Homebrew/homebrew-core#26959

Closed

4 tasks

dlemstra mentioned this pull request Apr 23, 2018

only base_offset_size=0 and index_size=0 are supported #1105

Closed

3 tasks

restore all files generated by autotools to their original state from…

eddeb16

… master branch

dlemstra merged commit 4179457 into ImageMagick:master Apr 27, 2018

steiny2k mentioned this pull request Aug 28, 2018

Feature request: HEIC support owncloud/gallery#737

Closed

chregu mentioned this pull request Oct 20, 2018

Alpha support for writing heif images? #1361

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added HEIF writer and replaced HEIF reader with a more complete HEIF implementation #1099

added HEIF writer and replaced HEIF reader with a more complete HEIF implementation #1099

farindk commented Apr 17, 2018 •

edited

Loading

dlemstra commented Apr 17, 2018

farindk commented Apr 17, 2018 via email

farindk commented Apr 17, 2018

dbtsai commented Apr 17, 2018

dlemstra commented Apr 17, 2018

dlemstra Apr 18, 2018

farindk commented Apr 25, 2018

dlemstra commented Apr 25, 2018

dlemstra commented Apr 26, 2018 •

edited

Loading

farindk commented Apr 26, 2018 •

edited

Loading

dlemstra commented Apr 26, 2018 •

edited

Loading

farindk commented Apr 26, 2018

dbtsai commented Aug 16, 2018

farindk commented Aug 17, 2018

dbtsai commented Aug 17, 2018 •

edited

Loading

added HEIF writer and replaced HEIF reader with a more complete HEIF implementation #1099

added HEIF writer and replaced HEIF reader with a more complete HEIF implementation #1099

Conversation

farindk commented Apr 17, 2018 • edited Loading

dlemstra commented Apr 17, 2018

farindk commented Apr 17, 2018 via email

farindk commented Apr 17, 2018

dbtsai commented Apr 17, 2018

dlemstra commented Apr 17, 2018

dlemstra Apr 18, 2018

Choose a reason for hiding this comment

farindk commented Apr 25, 2018

dlemstra commented Apr 25, 2018

dlemstra commented Apr 26, 2018 • edited Loading

farindk commented Apr 26, 2018 • edited Loading

dlemstra commented Apr 26, 2018 • edited Loading

farindk commented Apr 26, 2018

dbtsai commented Aug 16, 2018

farindk commented Aug 17, 2018

dbtsai commented Aug 17, 2018 • edited Loading

farindk commented Apr 17, 2018 •

edited

Loading

dlemstra commented Apr 26, 2018 •

edited

Loading

farindk commented Apr 26, 2018 •

edited

Loading

dlemstra commented Apr 26, 2018 •

edited

Loading

dbtsai commented Aug 17, 2018 •

edited

Loading