This repository has been archived by the owner on Jun 10, 2019. It is now read-only.
More changes found with updated regex #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: there is also a file at /downloader/lib/Mage/Connect/Packager.php that needs the same change that cannot be easily overridden by any means that I am aware of
|
There are numerous more (230 more) instances of |
|
The other pull request I created (#22) has these changes as well. So you may want to just merge that one and disregard this one if that's the way you want to go. There's a comment on that other pull request regarding this as well. Sorry about that. |
|
Disregarding this pull request, as recommended by author. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this page (http://php.net/manual/en/migration70.incompatible.php#migration70.incompatible.variable-handling),
I generated a more in-depth regex to search for variable names that might cause issues.
That regex is here:
There was an additional file found in
downloader/lib/Mage/Connect/Packager.phpthat requires the same changes as the ones inapp/code/local/Mage/Connect/Packager.phpwhich overrideslib/Mage/Connect/Packager.php. Because I am uncertain how to override that file, I was unable to include it in this pull request. But it should still be noted and/or added in the future.