Skip to content
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.

Enterprise level changes #22

Closed
wants to merge 3 commits into from
Closed

Enterprise level changes #22

wants to merge 3 commits into from

Conversation

benjamw
Copy link
Contributor

@benjamw benjamw commented Mar 3, 2016

One more change on the enterprise level. Not sure if you want to make a new enterprise branch, or just include this in the master branch.

NOTE: there is also a file at /downloader/lib/Mage/Connect/Packager.php
that needs the same change that cannot be easily overridden by any
means that I am aware of
@benjamw
Copy link
Contributor Author

benjamw commented Mar 3, 2016

Sorry, somehow this got the master branch changes as well... I can fix it if you want me to. Just let me know.

@icurdinj
Copy link
Contributor

icurdinj commented Mar 7, 2016

Sorry for the late reply! This looks EE specific, so it might be wise to make a separate branch and release... Please have a little more patience, I have to test this on EE, and find a good strategy for CE & EE releases...

@icurdinj icurdinj self-assigned this Mar 7, 2016
@benjamw
Copy link
Contributor Author

benjamw commented Mar 7, 2016

If it's any consolation, I'm using this on both EE and CE, and it seems to work fine on both. There are no errors reported on CE that it's trying to find any missing EE classes.

@icurdinj
Copy link
Contributor

icurdinj commented Mar 9, 2016

I just made a separate branch for EE. Could you please make a new pull request for this against the EE branch? Or maybe retarget this one, I'm not sure if that's possible.
(Even if it doesn't trigger errors on CE, it doesn't seem allright to push EE specific code to everyone. We'll make two separate releases.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants