Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 9 & OnPush #28

Closed
JETiCODEV opened this issue Feb 12, 2020 · 12 comments
Closed

Angular 9 & OnPush #28

JETiCODEV opened this issue Feb 12, 2020 · 12 comments
Labels
bug Something isn't working need repro

Comments

@JETiCODEV
Copy link

Hi,

Just upgrade to Angular 9 and seems to be that the library doesn't work when all components are OnPush. Any ideas on how to fix this ?

@thekiba
Copy link
Contributor

thekiba commented Feb 12, 2020

Hi @JETiCODEV,

thanks for the issue. Could you please reproduce your problem and put the link here?

@thekiba thekiba added bug Something isn't working need repro labels Feb 12, 2020
@JETiCODEV
Copy link
Author

@JETiCODEV
Copy link
Author

I pulled the ngxd source into our project and made a quick change, seems to be that adding this line to attachContextPropertyToComponentInput "solves" it:

image

@thekiba
Copy link
Contributor

thekiba commented Feb 12, 2020

@JETiCODEV thanks! I'll check it and publish new release ASAP.

@JETiCODEV
Copy link
Author

JETiCODEV commented Feb 12, 2020

@thekiba seems to be that when running it in stackblitz it just works, but I tried to run it locally (fresh Angular setup) and there it doesn't work ...

Seems that I shared the wrong stackblitz https://stackblitz.com/edit/angular-9-0-0-rc-1-wn3nvu?file=src/app/app.module.ts

@JETiCODEV
Copy link
Author

Seems to be that works in Stackblitz, but not in a fresh angular project. So I pushed the changes into a test repo, hope that will help. This is the working version, if you want to play around better to revert the mentioned change.

https://github.com/JETiCODEV/test

@thekiba
Copy link
Contributor

thekiba commented Feb 18, 2020

I published new version v9.0.1, try to check this

@JETiCODEV
Copy link
Author

Great, thanks! Will give it a try.

@JETiCODEV
Copy link
Author

Just tried to add the new library to my existing project but it results in the following error:
image

@thekiba
Copy link
Contributor

thekiba commented Feb 19, 2020

So sorry, I forgot to build for a ViewEngine 😅 Now it's should be works, please use v9.0.2 🙏

@JETiCODEV
Copy link
Author

Great, it's working ! Thanks for the effort, btw this library is really great in combination with Angular 9 ! Keep up to good work !

@thekiba
Copy link
Contributor

thekiba commented Feb 19, 2020

Yeah, thanks 😁 With Angular 9 is really powerful, check this some use cases with lazily components and resolve pipe https://twitter.com/thekiba_io/status/1230076631722659841?s=20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need repro
Projects
None yet
Development

No branches or pull requests

2 participants