updated libraries folder #195

IFX-Anusha · 2022-07-27T07:55:46Z

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Provide the information we need to review your PR. What problem does the pull request solve? "Bug fix" is not a good description.

Related Issue
If you opened an issue before creating the PR, point to it here.

Context
What do we need to know about your development environment, tools, target, and so on. Screenshots are always helpful if there is a UI element to this PR.

techpaul

This appears to me a MASS deletion of libraries YOU have NOT used

Many are for benefit of others and one you have deleted would make YOUR examples board AGNOSTIC, namely LED, which means an example can use LED.Add( pin) and LED.On or LED.Off or LED.Toggle to ALWAYS work on any board whatever method of On being 1 or 0.

This is determined by define XMC_LED_ON in pins_arduino.h
This may break other examples and libraries.

Highlly suspicious of how this PR has been done

techpaul

Most RTC functions are supported on XMC1 series AS WELL

Hibernate support was dropped three years ago as Arduino framework does not support detection of Reset from hibernate and staorage to restore system state (including ALL buffers)

jaenrig-ifx · 2022-07-28T08:39:28Z

libraries/SPI/src/utility/xmc_spi_conf.c

@@ -107,46 +107,6 @@ XMC_SPI_t XMC_SPI_0 =
    }
 };

-#elif defined(XMC1400_Arduino_Kit) 


Mmm ... the fork has not been updated to the latest develop-2.x branch. And the board is removed from the built-in library. I believe this is one of the boards to keep in 2.x.

Yes it should stay as the XMC1400 will be the successor or the XMC1100

Yes. Will update that

Sounds like internal Infineon converstaions and dreams on a public repo

Hopefully with better layout, documentation.

Maybe also allow other versions to be added like using XMC1400 64 pin variant, I am background working on.

jaenrig-ifx · 2022-07-28T08:39:59Z

libraries/SPI/src/utility/xmc_spi_conf.h

@@ -60,10 +60,6 @@ extern XMC_SPI_t XMC_SPI_0;
 #define NUM_SPI  			1
 extern XMC_SPI_t XMC_SPI_0;

-#elif defined(XMC1400_Arduino_Kit)


Same as xmc_spi_conf.c

jaenrig-ifx · 2022-07-28T08:41:54Z

libraries/Wire/src/utility/xmc_i2c_conf.c

@@ -197,40 +197,6 @@ XMC_I2C_t XMC_I2C_0 =
    .protocol_irq_service_request       	  = 5
 };

-#elif defined(XMC1400_Arduino_Kit) 


Same as xmc_spi_conf.c

jaenrig-ifx · 2022-07-28T08:42:03Z

libraries/Wire/src/utility/xmc_i2c_conf.h

@@ -64,10 +64,6 @@ extern XMC_I2C_t XMC_I2C_1;
 #define NUM_I2C  1
 extern XMC_I2C_t XMC_I2C_0;

-#elif defined(XMC1400_Arduino_Kit)


Same as xmc_spi_conf.c

jaenrig-ifx · 2022-07-28T08:54:20Z

@techpaul this develop-2.x is a minimal implementation of xmc-for-arduino.
The current develop/master (v1.x) keeps all the built-in libs.

Only some relevant boards and built-in libraries building and functionally evaluated will be kept.
Many of them will be added later (again) as they are functionally verified and provided testing examples which can be automated and skipped specific hardware dependencies like external sensors, etc.

techpaul · 2022-07-28T09:37:36Z

@jaenrig-ifx

@techpaul this develop-2.x is a minimal implementation of xmc-for-arduino. The current develop/master (v1.x) keeps all the built-in libs.

Lack of overall description and any details, sounds like an internal test that should have been a separate internal FORK first.

Only some relevant boards and built-in libraries building and functionally evaluated will be kept. Many of them will be added later (again) as they are functionally verified and provided testing examples which can be automated and skipped specific hardware dependencies like external sensors, etc.

So so automated testing and inability to catch the mistake in the same device SPI test, with no external sensors

techpaul · 2022-07-28T09:41:02Z

A better rework would be to move the xmc_pi_conf and xmc_i2c_conf files to variants folder, for easier maintainability. Note this makes NO difference to compilation paths if in same folder as pins_arduino.h

techpaul

Remove functionality for Hiberante examples

techpaul · 2022-07-27T09:21:28Z

libraries/RTC/Readme.MD

@@ -0,0 +1,6 @@
+# RTC Library for XMC
+
+This is the real time clock library that is supported by XMC4700


XMC1 series as well as XMC4 EXCEPT Hibernate which was dropped from Device control 3 years ago

techpaul · 2022-07-27T09:28:52Z

libraries/SPI/examples/SPI_MOSI_to_MISO_SameDevice/SPI_MOSI_to_MISO_SameDevice.ino

+int i = 0;                                                         
+void setup() 
+{
+  pinMode(LED1, OUTPUT);                                           // setting the LED pin as output


1 use LED library to be board agnostic about LED on is high or low
2 Use LED2 as LED 1 is also SPI-SCK on most boards, so could have other disturbances to your SPI (or no effect)

Either you are seeing the HARDWIRED effect of LED1 (BUILTIN_LED) and the LED code is pointless or some other effect is happening

Using LED library and LED2 will meant this will work on nearly every board including XMC2GO

Lack of comments at start to say what it does how to configure even hardware makes this a poor example/test "feature"

techpaul · 2022-07-27T09:29:29Z

libraries/SPI/examples/SPI_MOSI_to_MISO_SameDevice/SPI_MOSI_to_MISO_SameDevice.ino

+}
+void loop() 
+{    
+  digitalWrite(LED1, HIGH);   


See previous comments on LED

techpaul · 2022-07-28T09:32:33Z

libraries/SPI/src/utility/xmc_spi_conf.c

@@ -107,46 +107,6 @@ XMC_SPI_t XMC_SPI_0 =
    }
 };

-#elif defined(XMC1400_Arduino_Kit) 


Sounds like internal Infineon converstaions and dreams on a public repo

techpaul · 2022-07-28T09:33:58Z

libraries/SPI/src/utility/xmc_spi_conf.c

@@ -107,46 +107,6 @@ XMC_SPI_t XMC_SPI_0 =
    }
 };

-#elif defined(XMC1400_Arduino_Kit) 


Hopefully with better layout, documentation.

Maybe also allow other versions to be added like using XMC1400 64 pin variant, I am background working on.

techpaul · 2022-07-28T11:30:45Z

libraries/RTC/examples/HibernateRTCAlarm/HibernateRTCAlarm.ino

@@ -0,0 +1,62 @@
+/*


Let me explain this another way, this example has been deleted from relase version of XMC-for-Arduino something like 3 years ago.

The person who wrote this example did not understand how Hibernate works, when the CPU comes out of hibernate the CPU is RESET apart from hibernate falags. This means the code will run Setup and Loop again

The function alarmMatch() will NEVER be reached.

xmc.enableHibernate was removed from DeviceControl library ages ago this example should be removed.

This suggests your base for develop-2.x was based on a VERY OLD version of the package

A better rework would be to move the xmc_pi_conf and xmc_i2c_conf files to variants folder, for easier maintainability. Note this makes NO difference to compilation paths if in same folder as pins_arduino.h

Yes, that will be considering in an upcoming improvement 👍

jaenrig-ifx · 2022-08-01T10:03:18Z

Together with the upcoming board clean up 👍

updated libraries folder

33658e7

techpaul suggested changes Jul 27, 2022

View reviewed changes

jaenrig-ifx reviewed Jul 28, 2022

View reviewed changes

OlafFilies self-requested a review July 28, 2022 08:48

updated spi and i2c config files and updated led lib

54561ed

techpaul suggested changes Jul 28, 2022

View reviewed changes

IFX-Anusha added 4 commits July 28, 2022 17:03

deleted hibernate

59cf6d3

updated action flows

46e11fa

updated action flows

83f3c77

updated action flows

9f943d3

jaenrig-ifx approved these changes Aug 1, 2022

View reviewed changes

OlafFilies approved these changes Aug 1, 2022

View reviewed changes

jaenrig-ifx merged commit d47e49a into Infineon:develop-2.x Aug 8, 2022

boramonideep mentioned this pull request Apr 4, 2023

Refactored built-in libraries #235

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updated libraries folder #195

updated libraries folder #195

IFX-Anusha commented Jul 27, 2022

techpaul left a comment

techpaul left a comment

jaenrig-ifx Jul 28, 2022

OlafFilies Jul 28, 2022

IFX-Anusha Jul 28, 2022 •

edited

techpaul Jul 28, 2022

techpaul Jul 28, 2022

jaenrig-ifx Jul 28, 2022

jaenrig-ifx Jul 28, 2022

jaenrig-ifx Jul 28, 2022

jaenrig-ifx commented Jul 28, 2022

techpaul commented Jul 28, 2022

techpaul commented Jul 28, 2022

techpaul left a comment

techpaul Jul 27, 2022

techpaul Jul 27, 2022

techpaul Jul 28, 2022

techpaul Jul 27, 2022

techpaul Jul 28, 2022

techpaul Jul 28, 2022

techpaul Jul 28, 2022

techpaul Jul 28, 2022

jaenrig-ifx Aug 1, 2022

jaenrig-ifx commented Aug 1, 2022

		@@ -0,0 +1,6 @@
		# RTC Library for XMC

		This is the real time clock library that is supported by XMC4700

updated libraries folder #195

updated libraries folder #195

Conversation

IFX-Anusha commented Jul 27, 2022

techpaul left a comment

Choose a reason for hiding this comment

techpaul left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IFX-Anusha Jul 28, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaenrig-ifx commented Jul 28, 2022

techpaul commented Jul 28, 2022

techpaul commented Jul 28, 2022

techpaul left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaenrig-ifx commented Aug 1, 2022

IFX-Anusha Jul 28, 2022 •

edited