Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored built-in libraries #235

Merged
merged 10 commits into from
Apr 5, 2023
Merged

Conversation

boramonideep
Copy link
Collaborator

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Refactored built-in libraries to remove board-specific information

Related Issue
Issue comment: #195 (comment)

Context
Refactored built-in libraries to remove board-specific macros and instances. These have been now moved to the board config files with Arduino.h serving as the obvious link in between them.

@techpaul
Copy link
Contributor

techpaul commented Apr 4, 2023

Makes the libraries more board agnostic

My original comment was to move edited for each variant the i2c and spi conf files to variants config folder and change the

#include "utility/xmc_i2c_conf.h"

to
#include <xmc_i2c_conf.h>

This method works as well

Copy link
Contributor

@techpaul techpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplifies library maintenance and makes new boards easier to add

@boramonideep boramonideep merged commit b74cf8f into Infineon:develop Apr 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants