Arrow Storm gives attack bonus vs. district defenses

[Infixo]

From @mrobaczyk Arrow Storm bonus gives also +7 CS vs district defences. Check LOC_PROMOTION_ARROW_STORM_DESCRIPTION

Seems like there is a buggy subject requirement

<RequirementSetId>ARROW_STORM_REQUIREMENTS</RequirementSetId>
<RequirementId>OPPONENT_IS_NOT_AIR_UNIT_REQUIREMENTS</RequirementId>
<RequirementId>PLAYER_IS_ATTACKER_REQUIREMENTS</RequirementId>

"District" is a separate opponent type, so "not air" includes also district. Solution probably depends on context, either make separate opponent types or exclude district defenses.

[Infixo]

Seems like in RequirementArguments we cannot use multiple items at once. This does not work.

-- test if for reqs args we can use commas too - NO!
-- There is a total of 871 reqs; 575 start with 'REQUIRES', 36 ends with 'REQUIREMENTS'
INSERT INTO Requirements (RequirementId, RequirementType) VALUES
('REQUIRES_OPPONENT_IS_LAND_OR_SEA_UNIT', 'REQUIREMENT_OPPONENT_UNIT_DOMAIN_MATCHES');
INSERT INTO RequirementArguments (RequirementId, Name, Value) VALUES
('REQUIRES_OPPONENT_IS_LAND_OR_SEA_UNIT', 'UnitDomain', 'DOMAIN_LAND,DOMAIN_SEA');
INSERT INTO RequirementSetRequirements (RequirementSetId, RequirementId) VALUES
('ARROW_STORM_REQUIREMENTS', 'REQUIRES_OPPONENT_IS_LAND_OR_SEA_UNIT');

[Infixo]

Fixed in b75d4bc.