Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved core code form ikMail share extension. #45

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Moved core code form ikMail share extension. #45

merged 2 commits into from
Jul 11, 2023

Conversation

adrien-coye
Copy link
Contributor

Misc

This contains:

  • Expanding ParallelTaskMapper to work with abstracted collections that match correct swift core protocols. (Sequence & Collection)
    • So we can use it with ArraySlice, without having to spown a new Array() each time
    • Also works for free with Dictionary now
    • Unit tested
  • Closure kit, first small iteration
    • Define a base closure type
    • Can happend them, and execute them.
    • Unit tested

@adrien-coye adrien-coye self-assigned this Jul 7, 2023
@adrien-coye adrien-coye requested a review from a team as a code owner July 7, 2023 15:07
@adrien-coye adrien-coye mentioned this pull request Jul 7, 2023
Merged
adrien-coye
adrien-coye commented Jul 11, 2023
View reviewed changes
Copy link
Contributor Author

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @PhilippeWeidmann

Sources/InfomaniakCore/ClosureKit/AsyncCurriedClosure.swift Outdated Show resolved Hide resolved
Sources/InfomaniakCore/ClosureKit/CurriedClosure.swift Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@PhilippeWeidmann PhilippeWeidmann merged commit 5a36a9a into master Jul 11, 2023
1 of 2 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the ikMailShareExtension branch July 21, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann approved these changes

Assignees

@adrien-coye adrien-coye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien-coye @PhilippeWeidmann