Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Re enable restoration #1190

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented May 28, 2024

Abstract

Re-enable a state restoration in kDrive based on the UISceneDelegate refactor
Main PR to switch to UISceneDelegate #1187

As discussed, this will focus on

  • MainTabViewController
  • StoreViewController
  • FileDetailViewController
  • PreviewViewController
  • FileListViewController

This now uses the common way to load each screen. We navigate to it with a "router"
In the case of a state restoration, we do navigation calls on startup.

Main PR #1187

@adrien-coye adrien-coye force-pushed the releaseAPIV3-restorationScene-reEnableRestoration branch from 723f212 to 92eb9dd Compare May 30, 2024 13:47
@adrien-coye adrien-coye marked this pull request as ready for review June 19, 2024 13:56
@adrien-coye adrien-coye force-pushed the releaseAPIV3-restorationScene-reEnableRestoration branch from f1de507 to 32d7a09 Compare June 19, 2024 14:02
Copy link
Contributor Author

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a self assessment

kDrive/AppRestorationService.swift Show resolved Hide resolved
kDrive/SceneDelegate.swift Outdated Show resolved Hide resolved
kDrive/AppRouter.swift Outdated Show resolved Hide resolved
kDrive/AppRouter.swift Outdated Show resolved Hide resolved
kDrive/SceneDelegate.swift Show resolved Hide resolved
kDrive/AppRouter.swift Outdated Show resolved Hide resolved
adrien-coye and others added 10 commits June 20, 2024 14:42
Co-authored-by: Philippe Weidmann <philippe.weidmann@infomaniak.com>
Co-authored-by: Philippe Weidmann <philippe.weidmann@infomaniak.com>
Co-authored-by: Philippe Weidmann <philippe.weidmann@infomaniak.com>
Co-authored-by: Philippe Weidmann <philippe.weidmann@infomaniak.com>
fix: Navigate back mutates the scene state
Copy link

sonarcloud bot commented Jun 21, 2024

@adrien-coye adrien-coye merged commit b210641 into releaseAPIV3-restorationScene Jun 21, 2024
2 checks passed
@adrien-coye adrien-coye deleted the releaseAPIV3-restorationScene-reEnableRestoration branch June 21, 2024 13:15
@adrien-coye adrien-coye added this to the APIV3 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants