-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Re enable restoration #1190
Merged
adrien-coye
merged 33 commits into
releaseAPIV3-restorationScene
from
releaseAPIV3-restorationScene-reEnableRestoration
Jun 21, 2024
Merged
feat: Re enable restoration #1190
adrien-coye
merged 33 commits into
releaseAPIV3-restorationScene
from
releaseAPIV3-restorationScene-reEnableRestoration
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-restorationScene-reEnableRestoration
5 tasks
adrien-coye
commented
May 28, 2024
adrien-coye
commented
May 28, 2024
adrien-coye
commented
May 30, 2024
adrien-coye
force-pushed
the
releaseAPIV3-restorationScene-reEnableRestoration
branch
from
May 30, 2024 13:47
723f212
to
92eb9dd
Compare
adrien-coye
force-pushed
the
releaseAPIV3-restorationScene-reEnableRestoration
branch
from
June 19, 2024 14:02
f1de507
to
32d7a09
Compare
adrien-coye
commented
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a self assessment
kDrive/UI/Controller/Files/File List/FileListViewController.swift
Outdated
Show resolved
Hide resolved
kDrive/UI/Controller/Files/File List/FileListViewController.swift
Outdated
Show resolved
Hide resolved
kDrive/UI/Controller/Files/FileActionsFloatingPanelViewController+Actions.swift
Outdated
Show resolved
Hide resolved
kDrive/UI/Controller/Files/File List/FileListViewController.swift
Outdated
Show resolved
Hide resolved
kDrive/UI/Controller/Files/File List/FileListViewController.swift
Outdated
Show resolved
Hide resolved
adrien-coye
commented
Jun 20, 2024
adrien-coye
commented
Jun 20, 2024
adrien-coye
commented
Jun 20, 2024
Co-authored-by: Philippe Weidmann <philippe.weidmann@infomaniak.com>
Co-authored-by: Philippe Weidmann <philippe.weidmann@infomaniak.com>
Co-authored-by: Philippe Weidmann <philippe.weidmann@infomaniak.com>
Co-authored-by: Philippe Weidmann <philippe.weidmann@infomaniak.com>
fix: Navigate back mutates the scene state
Quality Gate passedIssues Measures |
PhilippeWeidmann
approved these changes
Jun 21, 2024
adrien-coye
deleted the
releaseAPIV3-restorationScene-reEnableRestoration
branch
June 21, 2024 13:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Re-enable a state restoration in kDrive based on the UISceneDelegate refactor
Main PR to switch to UISceneDelegate #1187
As discussed, this will focus on
This now uses the common way to load each screen. We navigate to it with a "router"
In the case of a state restoration, we do navigation calls on startup.
Main PR #1187