Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Drop min & raw format #464

Merged
merged 5 commits into from
Oct 28, 2017
Merged

[RFR] Drop min & raw format #464

merged 5 commits into from
Oct 28, 2017

Conversation

touv
Copy link
Contributor

@touv touv commented Oct 27, 2017

it's not standard, so it's routine

@parmentf
Copy link
Contributor

parmentf commented Oct 27, 2017 •
edited
Loading

You did not remove src/api/exporters/exportMin.spec.js, making the tests fail.

@touv
Copy link
Contributor Author

touv commented Oct 28, 2017

thanks for the review, i improve again this PR, to drop useless statements.
I have patched "resource" format, to use another route, because "min" export doesn't work as expected

@parmentf parmentf merged commit b0b82fb into master Oct 28, 2017
@touv touv deleted the drop-min-format branch November 12, 2017 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@touv @parmentf