Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support underlines in codeblock syntax highlighting #221

Merged

Conversation

CosmicHorrorDev
Copy link
Collaborator

When I was looking through $ bat --list-themes I noticed that the Dracula theme (which we now support) uses underlines in some parts of the syntax highlighting

Demo

bat for reference

image

inlyne with this PR

image


Aside: we should support coloring underlines to match the text color

@CosmicHorrorDev CosmicHorrorDev added C-enhancement Category: New feature or request A-theme Area: Themes, system theme detection, and syntax highlighting labels Jan 24, 2024
@CosmicHorrorDev CosmicHorrorDev merged commit 9516097 into Inlyne-Project:main Jan 25, 2024
9 checks passed
@CosmicHorrorDev CosmicHorrorDev added the A-interpreter Area: Changes impacting the HTML interpreter label Feb 12, 2024
@CosmicHorrorDev CosmicHorrorDev deleted the codeblock-underline branch February 16, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-interpreter Area: Changes impacting the HTML interpreter A-theme Area: Themes, system theme detection, and syntax highlighting C-enhancement Category: New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant