Add support for color-scheme dependent pictures #236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #231
Adds support for color-scheme dependent
<picture>
s likewhich displays like so on this PR
Implementation-wise the main parts involved
color_scheme: Option<ResolvedTheme>
through everything to represent theNone
(defaultsrc
),Some(Dark)
(dark'ssrcset
), andSome(Light)
(light'ssrcset
)<picture>
meta-element which was done using apicture::Builder
that stores relevant information from the various elements and finalizes on the closing tag. Overall I'm rather happy with this approach to complex elements