-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Processing Errors (Alpha Build) #14
Comments
Can you upload the log file? |
Tried to reproduce the error again to get a clean log. Instead, I believe the problem is that if you try and pull down a file that already exists in the database, it pulls the file, then instead of moving it to the library once processed, deletes it. It worked on other new files that it hadn't seen before. |
Here is how the rename process works:
With that in mind - Manga Tagger is working as intended. It finds that a file (should) have already been processed under the new filename, and since the file that's currently being processed is not an upgrade, it deletes the file. That being said, we are going to want to clear out the processed_files table for you, since you are running an alpha build. Do you have MongoDB Compass set up on your computer? |
Also, a couple more things.
|
Ok retested everything on a fresh VM and I am going to try and go down the list.
I was also looking into volume creation and it looks like if the .cbz file has the folders in A-Z order, a unified document can be created. Such that say fileA.cbz has *** 001, *** 002, and *** 003 as separate folders inside of it, the file will open with the chapters in the correct order. Was thinking this may be a easy way to implement a easy volume creation protocol designed purely to just create a single document that every time a new chapter is added, is unzipped, new content added, and rezipped. |
Wasn't sure where I could put this, so I will just add this here. Going along with the Komga metadata thing, I found some projects that may be helpful as reference with pulling cover art compatible with Komga at the same time as the metadata. |
To your point 1 - yes, the database keeps a record of all files that Manga Tagger processes. It does this so that it can determine if a "v2" or some other upgrade of the file was downloaded and is being processed. Therefore if an upgrade is determined not necessary, then the new file is just deleted. It does this to prevent duplicates in the library location. I do think it would be a great idea to scan the library location and proceed as standard if the file is not there, so I will proceed with that. Volume creation is next on my list of features to implement, so thanks for your research into it, I'll definitely be looking into it once I finish refining this 1.1.x-alpha. Currently working on the oneshot issue, and will use the manga you linked to develop further test cases. |
Also - G-Maru Edition; what was the filename that Manga Tagger was trying to process? I need to know because another case I had, Peach Girl Next [EN] is different than the MAL name. I won't know how to account for the filename without having what is named as from the source. |
From FMD its (G) Edition. |
When you do get a chance check out the code here: On a side note, I was wondering if it would be possible to have the opened menu when the .exe is run display the ongoing processed like a CL command? It would make it a little easier to see if its still working or if it is hung on a process. |
In the settings.json under logger - set the "console" block to true as follows
Also, what source from FMD? |
Mangadex |
Fixed series verification in 1d05a2b |
Program now will run, rename, and create the metadata files correctly. However, it does not seem to be stable. When going from one series to another, a error is encountered and the metadata files fail to be generated. Furthermore, it seems the tagger does not seem to work with series that go by multiple names (Ex. Japanese title and English titles differ), even if there is only one possible search result.
On a side note, it may be useful to have a series metadata file created in the parent folder of the processed .cbz files, this way programs like Komga will show a description for the work without having to open one of the nested files.
The text was updated successfully, but these errors were encountered: