Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Auto Replace for Deprecation not working correctly #1823

Closed
pseudoankit opened this issue Mar 15, 2024 · 2 comments
Closed

[Enhancement] Auto Replace for Deprecation not working correctly #1823

pseudoankit opened this issue Mar 15, 2024 · 2 comments

Comments

@pseudoankit
Copy link

pseudoankit commented Mar 15, 2024

Describe the bug
auto replacement for deprecated method getViewModel is not correct

To Reproduce
Go to studio, alt enter on getViewModel()

Expected behavior
val foo = koinViewModel<ViewModel>()

Actual

rememberCurrentKoinScope()
    checkNotNull(LocalViewModelStoreOwner.current) {
        "No ViewModelStoreOwner was provided via LocalViewModelStoreOwner"
    }
    defaultExtras(viewModelStoreOwner)
    rememberCurrentKoinScope()
    val foo = koinViewModel

Koin module and version:
[e.g]: koin-core:3.4.3

Snippet or Sample project to help reproduce
Add a snippet or even a small sample project to hel reproduce your case.

@pseudoankit
Copy link
Author

pseudoankit commented Mar 15, 2024

I have done the change in local let me know if I can raise the pr?

Copy link

stale bot commented Aug 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:wontfix label Aug 12, 2024
@stale stale bot closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant