Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: switch to zlib-ng official repository #2803

Merged
merged 3 commits into from Oct 15, 2021

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Oct 11, 2021

Now that biggest PR to zlib-ng was merged, we can switch to the official repository.

Edit: all my PRs were merged, now we can directly use upstream.

@github-actions github-actions bot added area:ThirdParty Issues affecting the ThirdParty module type:Enhancement Improvement of existing methods or implementation labels Oct 11, 2021
dzenanz added a commit to dzenanz/zlib-ng that referenced this pull request Oct 11, 2021
From ITK PR: InsightSoftwareConsortium/ITK#2803
CI check: https://github.com/InsightSoftwareConsortium/ITK/runs/3864083025

commit 5434d42 adds bad whitespace:
README.md:223: new blank line at EOF.

commit 5434d42 is not allowed; missing newline at the end of file in .gitattributes.
Dead2 pushed a commit to zlib-ng/zlib-ng that referenced this pull request Oct 13, 2021
From ITK PR: InsightSoftwareConsortium/ITK#2803
CI check: https://github.com/InsightSoftwareConsortium/ITK/runs/3864083025

commit 5434d42 adds bad whitespace:
README.md:223: new blank line at EOF.

commit 5434d42 is not allowed; missing newline at the end of file in .gitattributes.
@gdevenyi
Copy link
Contributor

A bunch of PRs just merged upstream. Might want to resync one more time before merge.

dzenanz and others added 3 commits October 14, 2021 18:30
Code extracted from:

    https://github.com/zlib-ng/zlib-ng.git

at commit a7b773697b34c19f246defc1ffb760b0d39be391 (develop).
# By Zlib-ng Upstream
* upstream-zlib-ng:
  zlib-ng 2021-10-13 (a7b77369)
@dzenanz
Copy link
Member Author

dzenanz commented Oct 14, 2021

I just saw that too. I am mostly on vacation this week and the next, so I will respond slowly 😄

@dzenanz dzenanz requested a review from gdevenyi October 14, 2021 22:47
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🥡

@dzenanz dzenanz merged commit 23082f0 into InsightSoftwareConsortium:master Oct 15, 2021
@dzenanz dzenanz deleted the zlib-ng branch October 15, 2021 11:49
nmoinvaz pushed a commit to nmoinvaz/zlib-ng that referenced this pull request Oct 22, 2021
From ITK PR: InsightSoftwareConsortium/ITK#2803
CI check: https://github.com/InsightSoftwareConsortium/ITK/runs/3864083025

commit 5434d42 adds bad whitespace:
README.md:223: new blank line at EOF.

commit 5434d42 is not allowed; missing newline at the end of file in .gitattributes.
nmoinvaz pushed a commit to nmoinvaz/zlib-ng that referenced this pull request Oct 22, 2021
From ITK PR: InsightSoftwareConsortium/ITK#2803
CI check: https://github.com/InsightSoftwareConsortium/ITK/runs/3864083025

commit 5434d42 adds bad whitespace:
README.md:223: new blank line at EOF.

commit 5434d42 is not allowed; missing newline at the end of file in .gitattributes.
Dead2 pushed a commit to zlib-ng/zlib-ng that referenced this pull request Dec 13, 2021
From ITK PR: InsightSoftwareConsortium/ITK#2803
CI check: https://github.com/InsightSoftwareConsortium/ITK/runs/3864083025

commit 5434d42 adds bad whitespace:
README.md:223: new blank line at EOF.

commit 5434d42 is not allowed; missing newline at the end of file in .gitattributes.
Dead2 pushed a commit to zlib-ng/zlib-ng that referenced this pull request Dec 24, 2021
From ITK PR: InsightSoftwareConsortium/ITK#2803
CI check: https://github.com/InsightSoftwareConsortium/ITK/runs/3864083025

commit 5434d42 adds bad whitespace:
README.md:223: new blank line at EOF.

commit 5434d42 is not allowed; missing newline at the end of file in .gitattributes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ThirdParty Issues affecting the ThirdParty module type:Enhancement Improvement of existing methods or implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants