Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor formatting issues #1050

Merged
merged 1 commit into from Oct 13, 2021
Merged

Fix minor formatting issues #1050

merged 1 commit into from Oct 13, 2021

Conversation

dzenanz
Copy link
Contributor

@dzenanz dzenanz commented Oct 11, 2021

From ITK PR: InsightSoftwareConsortium/ITK#2803
CI check: https://github.com/InsightSoftwareConsortium/ITK/runs/3864083025

commit 5434d42 adds bad whitespace:
README.md:223: new blank line at EOF.

commit 5434d42 is not allowed; missing newline at the end of file in .gitattributes.

From ITK PR: InsightSoftwareConsortium/ITK#2803
CI check: https://github.com/InsightSoftwareConsortium/ITK/runs/3864083025

commit 5434d42 adds bad whitespace:
README.md:223: new blank line at EOF.

commit 5434d42 is not allowed; missing newline at the end of file in .gitattributes.
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #1050 (43dbeae) into develop (b418e9c) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1050      +/-   ##
===========================================
- Coverage    79.48%   79.45%   -0.04%     
===========================================
  Files           85       85              
  Lines         8658     8658              
  Branches      1398     1398              
===========================================
- Hits          6882     6879       -3     
- Misses        1228     1231       +3     
  Partials       548      548              
Flag Coverage Δ
macos_clang 69.87% <ø> (-0.04%) ⬇️
macos_gcc 68.48% <ø> (-0.06%) ⬇️
ubuntu_clang 75.44% <ø> (-0.04%) ⬇️
ubuntu_clang_debug 75.56% <ø> (-0.03%) ⬇️
ubuntu_clang_inflate_allow_invalid_dist 75.18% <ø> (-0.04%) ⬇️
ubuntu_clang_inflate_strict 75.38% <ø> (-0.04%) ⬇️
ubuntu_clang_mmap 75.41% <ø> (-0.04%) ⬇️
ubuntu_clang_msan 75.44% <ø> (-0.04%) ⬇️
ubuntu_clang_pigz 36.17% <ø> (ø)
ubuntu_clang_pigz_no_optim 40.95% <ø> (ø)
ubuntu_clang_pigz_no_threads 35.68% <ø> (ø)
ubuntu_clang_reduced_mem 75.70% <ø> (-0.04%) ⬇️
ubuntu_gcc 74.82% <ø> (-0.06%) ⬇️
ubuntu_gcc_aarch64 76.71% <ø> (-0.07%) ⬇️
ubuntu_gcc_aarch64_compat_no_opt 74.49% <ø> (-0.07%) ⬇️
ubuntu_gcc_aarch64_no_acle 76.16% <ø> (-0.07%) ⬇️
ubuntu_gcc_aarch64_no_neon 76.48% <ø> (-0.07%) ⬇️
ubuntu_gcc_armhf 76.71% <ø> (-0.07%) ⬇️
ubuntu_gcc_armhf_compat_no_opt 74.45% <ø> (-0.07%) ⬇️
ubuntu_gcc_armhf_no_acle 76.99% <ø> (-0.07%) ⬇️
ubuntu_gcc_armhf_no_neon 77.27% <ø> (-0.07%) ⬇️
ubuntu_gcc_armsf 76.72% <ø> (-0.07%) ⬇️
ubuntu_gcc_armsf_compat_no_opt 74.45% <ø> (-0.07%) ⬇️
ubuntu_gcc_compat_no_opt 75.44% <ø> (-0.07%) ⬇️
ubuntu_gcc_compat_sprefix 74.73% <ø> (-0.07%) ⬇️
ubuntu_gcc_mingw_i686 0.00% <ø> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <ø> (ø)
ubuntu_gcc_no_avx2 76.78% <ø> (-0.07%) ⬇️
ubuntu_gcc_no_ctz 77.67% <ø> (-0.07%) ⬇️
ubuntu_gcc_no_ctzll 77.34% <ø> (-0.07%) ⬇️
ubuntu_gcc_no_pclmulqdq 73.56% <ø> (-0.07%) ⬇️
ubuntu_gcc_no_sse2 76.04% <ø> (-0.06%) ⬇️
ubuntu_gcc_no_sse4 73.91% <ø> (-0.07%) ⬇️
ubuntu_gcc_o3 74.03% <ø> (-0.07%) ⬇️
ubuntu_gcc_osb 76.80% <ø> (-0.05%) ⬇️
ubuntu_gcc_pigz 36.59% <ø> (+0.02%) ⬆️
ubuntu_gcc_pigz_aarch64 38.63% <ø> (+0.03%) ⬆️
ubuntu_gcc_ppc 74.51% <ø> (-0.07%) ⬇️
ubuntu_gcc_ppc64 77.55% <ø> (-0.06%) ⬇️
ubuntu_gcc_ppc64le 76.01% <ø> (-0.06%) ⬇️
ubuntu_gcc_ppc_no_power8 77.31% <ø> (-0.07%) ⬇️
ubuntu_gcc_s390x 75.86% <ø> (-0.06%) ⬇️
ubuntu_gcc_sparc64 78.58% <ø> (-0.07%) ⬇️
ubuntu_gcc_sprefix 74.51% <ø> (-0.06%) ⬇️
win64_gcc ∅ <ø> (∅)
win64_gcc_compat_no_opt ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/fuzz/minigzip_fuzzer.c 51.67% <0.00%> (-2.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b418e9c...43dbeae. Read the comment docs.

@Dead2 Dead2 merged commit a7b7736 into zlib-ng:develop Oct 13, 2021
Dead2 added a commit that referenced this pull request Dec 13, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050
@Dead2 Dead2 mentioned this pull request Dec 13, 2021
Dead2 added a commit that referenced this pull request Dec 20, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1071
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1071
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1071
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067 #1079
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 24, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067 #1079
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants