Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with flake8 5.0 #222

Closed
zsol opened this issue Aug 4, 2022 · 2 comments
Closed

Incompatible with flake8 5.0 #222

zsol opened this issue Aug 4, 2022 · 2 comments
Milestone
2.0

Comments

@zsol
Copy link
Member

zsol commented Aug 4, 2022 

  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/fixit/common/flake8_compat.py", line 135, in reset
    arguments=self.args,
AttributeError: 'Flake8CompatApplication' object has no attribute 'args'

That attribute was removed in PyCQA/flake8@8d3afe4 which got released in 5.0.0
@zsol zsol mentioned this issue Aug 8, 2022
Merged
@thatch
Copy link
Contributor

thatch commented Aug 13, 2022

fixit itself should probably also add a max constraint: https://github.com/Instagram/Fixit/blob/main/requirements.txt

@snapdgn snapdgn mentioned this issue Oct 5, 2022
Closed
@amyreese amyreese added this to the 2.0 milestone Oct 6, 2022
@amyreese
Copy link
Member

amyreese commented Apr 3, 2023

Jettisoning the flake8 wrapper in favor of flake8/pyflakes-inspired lint rules.

@amyreese amyreese closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@amyreese @thatch @zsol