Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conventional file path/line number separator (: instead of @) #397

Closed
samueljsb opened this issue Oct 9, 2023 · 3 comments · Fixed by #437
Closed

Conventional file path/line number separator (: instead of @) #397

samueljsb opened this issue Oct 9, 2023 · 3 comments · Fixed by #437

Comments

@samueljsb
Copy link
Contributor

The output when a line is reported uses the @ character to separate the filename from the line number, e.g:

path/to/some/module.py@91:12 An error is at this location.

This differs from most other tools, which use a colon. The colon syntax is understood by many other tools that parse output (e.g. mypy-json-report) and the file finder in most editors (e.g. VS Code). e.g:

path/to/some/module.py:91:12 An error is at this location.

Would the maintainers be open to changing the output format to be the same as other tools? It would (imo) make fixit output much easier to work with.

@samueljsb
Copy link
Contributor Author

Would the maintainers be open to a PR that changes this? If there is a concern about backwards compatibility, would a --format option be acceptable?

@meshy
Copy link

meshy commented Jan 12, 2024

This is related to #305

@jvllmr
Copy link
Contributor

jvllmr commented Jan 18, 2024

+1. When using with VSCode I would like the path/line/column link to lead me to the spot in the code instead of doing basically nothing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants