-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(behaviors): centralize behavior trigger code #726
chore(behaviors): centralize behavior trigger code #726
Conversation
…s/behaviors/helpers file
src/services/behaviors/helpers.ts
Outdated
UpdateAction, | ||
} from 'hyperview/src/types'; | ||
|
||
export const triggerBehaviors = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we're creating these new services, I'm curious what's the overlap between the new triggerBehaviors
method and the trigger
method available in the service's index. Maybe more just an naming issue that creates ambiguity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is decent overlap, but there are differences in their usage. We may want to create a separate task to consolidate these.
077e3a5
into
hardin/navigation-integration
…nks (#701) Updates and fixes to Hyperview navigation including - Support for deep link navigation: - Passing the deep link url as the `entrypointurl` will merge/replace the existing state with the incoming - <navigation> elements in the XML support <behaviors> with a trigger of "load" - Integration with the TypeScript migrated Hyperview release Includes - #612 - #615 - #618 - #622 - #623 - #624 - #625 - #626 - #632 - #637 - #640 - #641 - #642 - #643 - #651 - #656 - #657 - #686 - #690 - #691 - #698 - #722 - #726 - #727 - #728 - #729 - #730 - #733 Asana: https://app.asana.com/0/1204008699308084/1205634462686890/f --------- Co-authored-by: Florent Bonomo <flochtililoch+github@gmail.com>
Moving the behavior trigger code out of
hyper-ref
into a shared location to allow access by other componentsAsana: https://app.asana.com/0/1204008699308084/1205741965789631/f