chore(behaviors): centralize behavior trigger code #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/behaviors/helpers file
src/services/behaviors/helpers.ts
Outdated
| UpdateAction, | ||
| } from 'hyperview/src/types'; | ||
|
|
||
| export const triggerBehaviors = ( |
There was a problem hiding this comment.
As we're creating these new services, I'm curious what's the overlap between the new triggerBehaviors method and the trigger method available in the service's index. Maybe more just an naming issue that creates ambiguity
There was a problem hiding this comment.
There is decent overlap, but there are differences in their usage. We may want to create a separate task to consolidate these.
flochtililoch
approved these changes
Oct 17, 2023
hgray-instawork
merged commit 077e3a5
into
hardin/navigation-integration
1 check passed
hgray-instawork
added a commit
that referenced
this pull request
Nov 1, 2023
…nks (#701) Updates and fixes to Hyperview navigation including - Support for deep link navigation: - Passing the deep link url as the `entrypointurl` will merge/replace the existing state with the incoming - <navigation> elements in the XML support <behaviors> with a trigger of "load" - Integration with the TypeScript migrated Hyperview release Includes - #612 - #615 - #618 - #622 - #623 - #624 - #625 - #626 - #632 - #637 - #640 - #641 - #642 - #643 - #651 - #656 - #657 - #686 - #690 - #691 - #698 - #722 - #726 - #727 - #728 - #729 - #730 - #733 Asana: https://app.asana.com/0/1204008699308084/1205634462686890/f --------- Co-authored-by: Florent Bonomo <flochtililoch+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the behavior trigger code out of
hyper-refinto a shared location to allow access by other componentsAsana: https://app.asana.com/0/1204008699308084/1205741965789631/f