fix: deep link urls are not triggering navigation events #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgray-instawork
changed the title
flochtililoch
approved these changes
Oct 30, 2023
hgray-instawork
added a commit
that referenced
this pull request
Nov 1, 2023
…nks (#701) Updates and fixes to Hyperview navigation including - Support for deep link navigation: - Passing the deep link url as the `entrypointurl` will merge/replace the existing state with the incoming - <navigation> elements in the XML support <behaviors> with a trigger of "load" - Integration with the TypeScript migrated Hyperview release Includes - #612 - #615 - #618 - #622 - #623 - #624 - #625 - #626 - #632 - #637 - #640 - #641 - #642 - #643 - #651 - #656 - #657 - #686 - #690 - #691 - #698 - #722 - #726 - #727 - #728 - #729 - #730 - #733 Asana: https://app.asana.com/0/1204008699308084/1205634462686890/f --------- Co-authored-by: Florent Bonomo <flochtililoch+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deep link requests were not properly triggering navigation events like tab selections. Behaviors continued to work as expected.
Cause:
There was a chunk of code which was calling
useContextin the hv-navigator for two contexts. The result of these were not being used so the code was removed. Without that context, theuseEffectof the custom navigators doesn't fire.Adding it back as part of the hierarchy restores the functionality.
In the videos below, the deep link should cause a selection of the "Accounts" tab.