This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
Implement notna #247
Merged
Implement notna #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shssf
suggested changes
Oct 22, 2019
densmirn
suggested changes
Oct 25, 2019
| Parameters | ||
| ----------- | ||
| self : :obj:`pandas.Series` object | ||
| input argument |
There was a problem hiding this comment.
There is too long indentation.
| raise TypingError('{} The object must be a pandas.series. Given: {}'.format(_func_name, self)) | ||
|
|
||
| if isinstance(self.data.dtype, types.Number): | ||
|
|
There was a problem hiding this comment.
I think the empty line after if-statement is excess.
| if isinstance(self.data.dtype, types.Number): | ||
|
|
||
| def hpat_pandas_series_notna_impl(self): | ||
|
|
There was a problem hiding this comment.
I think the empty line as the first line of the function is excess.
hpat/tests/test_series.py
Outdated
Comment on lines
1766
to
1771
| data_test = [[6, 6, 2, 1, 3, 3, 2, 1, 2], | ||
| [1.1, 0.3, 2.1, 1, 3, 0.3, 2.1, 1.1, 2.2], | ||
| [6, 6.1, 2.2, 1, 3, 0, 2.2, 1, 2], | ||
| [6, 6, 2, 1, 3, np.inf, np.nan, np.nan, np.nan], | ||
| [3., 5.3, np.nan, np.nan, np.inf, np.inf, 4.4, 3.7, 8.9] | ||
| ] |
There was a problem hiding this comment.
I propose to use globally defined data as input data in tests: f2435b0#diff-deca39d332649cea819383154a5d2cb3R39-R62
1e-to
force-pushed
the
implement_notna
branch
from
d4e8311
to
085ae9a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.