Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying + pasting entities works only over a distance of viewdistance + 2 chunks #1826

Open
2 tasks done
TheoRetisch1 opened this issue Jun 17, 2022 · 9 comments · May be fixed by #2356
Open
2 tasks done

Copying + pasting entities works only over a distance of viewdistance + 2 chunks #1826

TheoRetisch1 opened this issue Jun 17, 2022 · 9 comments · May be fixed by #2356
Labels
Approved Added if an issue has been approved by a maintainer Bug Something isn't working Enhancement New feature or request upstream issue Something is broken in WorldEdit as well

Comments

@TheoRetisch1
Copy link

TheoRetisch1 commented Jun 17, 2022

Server Implementation

Paper

Server Version

1.18.2

Describe the bug

When using //copy -e not all entities are copied in larger selections, while copying blocks always works correctly.
Entities are copied only up to a distance of configured viewdistance + 2 chunks. After this distance is exceeded only blocks are considered. This behavior also applies to schematics, //paste -e and //move -e. However, //stack -e works correctly.

To Reproduce

  1. Find a chunk border using f3+g.
  2. Place two blocks, each holding an entity (e.g. an item frame).
  3. Select the blocks + entities and enter //stack 400 -e
    stacking
  4. Select all stacked blocks and entities (selection size: 1604)
  5. Move to your starting position next to the chunk border and enter //copy -e while all chunks are still loaded (output: 1604 blocks + 802 entities copied)
  6. Wait for 30s (paper.yml: delay-chunk-unloads-by: 30s) until all chunky are unloaded and enter //copy -e again (output: 1604 blocks + 192 entities copied). [view-distance = 12, simulation-distance= 4]

Expected behaviour

All entities in the selection should be copied, regardless of whether the chunks are loaded or not.

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/88c3858f83354ec3a5f7038c52269046

Fawe Version

FastAsyncWorldEdit version 2.3.1-SNAPSHOT-210;fd00635

Checklist

Anything else?

No response

@TheoRetisch1 TheoRetisch1 added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label Jun 17, 2022
@SirYwell
Copy link
Member

Might be related to PaperMC/Paper#5872

@dordsor21
Copy link
Member

dordsor21 commented Jun 17, 2022

This will almost certainly be it, as FAWE starts using the chunk as soon as it's loaded

@dordsor21
Copy link
Member

The methods in BukkitWorld for getting entities ultimately only ever get the loaded entities https://github.com/IntellectualSites/FastAsyncWorldEdit/blob/main/worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitWorld.java#L142-L165 which is completed before any chunks are loaded by FAWE in ForwardExtentCopy

@dordsor21 dordsor21 added Approved Added if an issue has been approved by a maintainer Bug Something isn't working upstream issue Something is broken in WorldEdit as well and removed Requires Testing This is a new issue which needs to be approved before labeled with "bug" labels Jun 17, 2022
@NotMyFault NotMyFault removed Bug Something isn't working Approved Added if an issue has been approved by a maintainer labels Aug 19, 2022
@NotMyFault NotMyFault closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2022
@dordsor21
Copy link
Member

Why did you close this? Having a system to load chunks for operations that otherwise wouldn't is a reasonable addition imo

@NotMyFault
Copy link
Member

Why did you close this? Having a system to load chunks for operations that otherwise wouldn't is a reasonable addition imo

You labeled this issue as upstream issue, which implies this is a WorldEdit issue. If you feel this is worth an addition, feel free to reopen and apply the enhancement label.

@dordsor21 dordsor21 reopened this Aug 20, 2022
@dordsor21 dordsor21 added Bug Something isn't working Enhancement New feature or request Approved Added if an issue has been approved by a maintainer labels Aug 20, 2022
@dordsor21
Copy link
Member

The upstream label was there cos it's also an upstream issue, not necessarily meaning it can/should only be fixed there

@Foorcee
Copy link
Contributor

Foorcee commented Nov 11, 2022

Maybe related to this problem:

When I copy entities, the absolute coordinates are saved or used.

  1. select area and copy with entities //copy -e
  2. save clipboard //schem save test resp. //schem save test_sponge sponge
  3. open Schematic with NBTExplorer

Test Setup:

File in NBT Explorer:

@OneLiteFeather
Copy link
Member

Can't reproduce the issue of this ticket anymore in 1.19.4 Paper-513 and FAWE-401, I tried as said, but the amount of entities stays the same after 1 minute even. Could be fixed by Paper

@OneLiteFeather
Copy link
Member

Maybe related to this problem:

When I copy entities, the absolute coordinates are saved or used.

1. select area and copy with entities //copy -e

2. save clipboard //schem save test resp. //schem save test_sponge sponge

3. open Schematic with NBTExplorer

Test Setup:

File in NBT Explorer:

Can you open an extra issue for that? It seems to be a problem regarding schematics and entity coordinates, I also came to the same result that pasting the schematic won't have the entities in the loaded and pasted selection, it is different from this issue.

dordsor21 added a commit that referenced this issue Jul 14, 2023
 - Add new extent that does an action on chunk GET load
 - closes #1826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Added if an issue has been approved by a maintainer Bug Something isn't working Enhancement New feature or request upstream issue Something is broken in WorldEdit as well
Projects
None yet
6 participants