Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//inspect does not show who performed the worldedit operation #2555

Closed
2 tasks done
Overwrite987 opened this issue Jan 28, 2024 · 9 comments · Fixed by #2591
Closed
2 tasks done

//inspect does not show who performed the worldedit operation #2555

Overwrite987 opened this issue Jan 28, 2024 · 9 comments · Fixed by #2591
Labels
Bug Something isn't working

Comments

@Overwrite987
Copy link

Server Implementation

Paper

Server Version

1.20.4

Describe the bug

When performing a worldedit operation, you cannot see through //inspect who performed it. it will write that no operation was performed, although it was not.

To Reproduce

  1. Install fawe
  2. use //set or other operation
  3. try to check it with //inspect
  4. you'll see that it shows nothing

Expected behaviour

it should show who performed the worldedit operation.

Screenshots / Videos

https://drive.google.com/file/d/1cuFBxBx7sSKW3hK30KPHhtgTlclyfK4w/view?usp=sharing

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/3dec3480cb1c44fa823de6ba4c88196a

Fawe Version

FastAsyncWorldEdit-646

Checklist

Anything else?

No response

@Overwrite987 Overwrite987 added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label Jan 28, 2024
@OneLiteFeather
Copy link
Member

Can reproduce this behaviour with fawe 659 and paper 1.20.4 (409), looks like there has something changed.

@OneLiteFeather OneLiteFeather added Bug Something isn't working help wanted Community assistance requested, PRs welcome. and removed Requires Testing This is a new issue which needs to be approved before labeled with "bug" labels Feb 7, 2024
@LordKnish
Copy link

Yep still exists in 659. I am not sure what to do about this because its a pretty big issue that opens up servers for griefing

@OneLiteFeather
Copy link
Member

Yep still exists in 659. I am not sure what to do about this because its a pretty big issue that opens up servers for griefing

does it affect griefing if you already put in trust when you give normal players worldedit permissions? Could be more an issue for other plugins relying on this feature if the bug is also happing for example on Coreprotect regarding the worldedit changes.
Can anyone check the severity and how to fix the bug? PRs are welcome.

@NotMyFault NotMyFault removed the help wanted Community assistance requested, PRs welcome. label Feb 13, 2024
@NotMyFault
Copy link
Member

NotMyFault commented Feb 13, 2024

does it affect griefing if you already put in trust when you give normal players worldedit permissions?

It doesn't. All that happens - or doesn't happen in that case - is a lacking ingame output of the history of actions.
The data is written correctly to the database still and can be accessed at any time if needed.
Screenshot 2024-02-13 at 16 20 10

@OneLiteFeather
Copy link
Member

So it is just an display issue?

@NotMyFault
Copy link
Member

So it is just an display issue?

Yes.

@LordKnish
Copy link

LordKnish commented Feb 13, 2024 via email

@NotMyFault
Copy link
Member

Rollback doesn't work though. I am unable to rollback

On Tue, Feb 13, 2024, 5:22 PM Alexander Brandes @.> wrote: So it is just an display issue? Yes. — Reply to this email directly, view it on GitHub <#2555 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABU7K7BGXKSCF76A6DHFJSTYTOAL5AVCNFSM6AAAAABCODGS6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBRG43TCNBZGY . You are receiving this because you commented.Message ID: @.>

That would be a different issue then, in that case, please file a separate issue.

@BestMark

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants