Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add null-check for brush in traceMask #2160

Merged
merged 3 commits into from
Mar 31, 2023
Merged

fix: add null-check for brush in traceMask #2160

merged 3 commits into from
Mar 31, 2023

Conversation

dordsor21
Copy link
Member

@dordsor21 dordsor21 requested a review from a team as a code owner March 25, 2023 11:42
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Mar 25, 2023
SirYwell
SirYwell approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAWE additionally has fawe.worldedit.brush.brush.none, would it make sense to replace usages of that (probably in a follow-up PR)?

NotMyFault
NotMyFault approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

worldedit-core/src/main/java/com/sk89q/worldedit/command/ToolUtilCommands.java Outdated Show resolved Hide resolved
@NotMyFault NotMyFault merged commit a9e1d50 into main Mar 31, 2023
@NotMyFault NotMyFault deleted the fix/tracemask-null-brush branch March 31, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirYwell SirYwell SirYwell approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
Bugfix This PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tracemask without brush set returns error
3 participants
@dordsor21 @SirYwell @NotMyFault