Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes command context for bukkit console command sender #2193

Merged
merged 5 commits into from
May 12, 2023
Merged

Fixes command context for bukkit console command sender #2193

merged 5 commits into from
May 12, 2023

Conversation

TheMeinerLP
Copy link
Member

Overview

Fixes #1994

Description

Thanks to @GiantTreeLP to help me to identify the issue with the console command sender from fawe/worldedit.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@TheMeinerLP TheMeinerLP requested a review from a team as a code owner April 28, 2023 22:22
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Apr 28, 2023
@TheMeinerLP TheMeinerLP changed the title Bugfix/1994 Fixes command context for bukkit console command sender Apr 28, 2023
PierreSchwang
PierreSchwang requested changes Apr 29, 2023
View reviewed changes
Copy link
Member

@PierreSchwang PierreSchwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise I'd say

worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/WorldEditPlugin.java Outdated Show resolved Hide resolved
worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/WorldEditPlugin.java Outdated Show resolved Hide resolved
@dordsor21 dordsor21 merged commit c57fee5 into IntellectualSites:main May 12, 2023
7 checks passed
@TheMeinerLP TheMeinerLP deleted the bugfix/1994 branch May 12, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattBDev MattBDev MattBDev approved these changes

@dordsor21 dordsor21 dordsor21 approved these changes

@SirYwell SirYwell SirYwell approved these changes

@PierreSchwang PierreSchwang Awaiting requested review from PierreSchwang

Assignees
No one assigned
Labels
Bugfix This PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use //confirm command in console
5 participants
@TheMeinerLP @MattBDev @dordsor21 @SirYwell @PierreSchwang