Actually delegate in AbstractDelegateExtent #2196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Description
AbstractDelegateExtent is missing methods that should delegate to the target extent. This leads to falling back to default implementations in Extent that typically perform worse than specialized implementations in the actual extents.
As an example,
//distr
performs ~15x faster with this change.I excluded the enableHistory method from delegating because it might delegate to the implementation in ExtentBatchProcessorHolder, returning a SingleThreadQueueExtent instead of the actual ParallelQueueExtent. I don't know why the implementation is built the way it is, so I think this needs to be investigated separately.
Submitter Checklist
@since TODO
.