Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually delegate in AbstractDelegateExtent #2196

Merged
merged 2 commits into from May 4, 2023

Conversation

SirYwell
Copy link
Member

Overview

Description

AbstractDelegateExtent is missing methods that should delegate to the target extent. This leads to falling back to default implementations in Extent that typically perform worse than specialized implementations in the actual extents.
As an example, //distr performs ~15x faster with this change.

I excluded the enableHistory method from delegating because it might delegate to the implementation in ExtentBatchProcessorHolder, returning a SingleThreadQueueExtent instead of the actual ParallelQueueExtent. I don't know why the implementation is built the way it is, so I think this needs to be investigated separately.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@SirYwell SirYwell requested a review from a team as a code owner April 30, 2023 09:41
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Apr 30, 2023
@NotMyFault NotMyFault merged commit 2987550 into main May 4, 2023
8 checks passed
@NotMyFault NotMyFault deleted the fix/abstract-delegate-extent branch May 4, 2023 16:33
SirYwell added a commit that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants