Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more intuitive limit permissions #2233

Merged
merged 1 commit into from
May 20, 2023
Merged

fix: more intuitive limit permissions #2233

merged 1 commit into from
May 20, 2023

Conversation

dordsor21
Copy link
Member

  • immediately return limit if unlimited (limit combination take the "higher" value)
  • add fawe.limit.unlimited permission and it's an intuitive permission to give

@dordsor21
fix: more intuitive limit permissions
4548fc1 
 - immediately return limit if unlimited (limit combination take the "higher" value)
 - add fawe.limit.unlimited permission and it's an intuitive permission to give
@dordsor21 dordsor21 requested a review from a team as a code owner May 20, 2023 10:04
@github-actions github-actions bot added the Bugfix This PR fixes a bug label May 20, 2023
@NotMyFault NotMyFault merged commit 1b0fb9e into main May 20, 2023
7 checks passed
@NotMyFault NotMyFault deleted the fix/limit-permissions branch May 20, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirYwell SirYwell SirYwell approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
Bugfix This PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dordsor21 @SirYwell @NotMyFault