Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow captions in SuggestInputParseException #2239

Merged
merged 1 commit into from May 22, 2023
Merged

feat: allow captions in SuggestInputParseException #2239

merged 1 commit into from May 22, 2023

Conversation

dordsor21
Copy link
Member

@dordsor21
feat: allow captions in SuggestInputParseException
361a929 
 - Deprecate for removal methods using string message
 - Fixes #2026
@dordsor21 dordsor21 requested a review from a team as a code owner May 21, 2023 10:38
@github-actions github-actions bot added the Feature This PR adds a new feature label May 21, 2023
NotMyFault
NotMyFault approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@NotMyFault NotMyFault merged commit 7c01c1e into main May 22, 2023
8 checks passed
@NotMyFault NotMyFault deleted the feat/captioned-suggest-input-exception branch May 22, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirYwell SirYwell SirYwell approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
Feature This PR adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Section translation not working fawe.error.invalid-block-type
3 participants
@dordsor21 @SirYwell @NotMyFault