Fix Linear pattern index incrementing above array length #2626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When running async the
#linear
pattern can increment index above the length of thepatternsArray
.This tends not to happen on small operations.
Replication steps for error:
//set #linear[1,2,3]
Description
Changes the index calculation to always modulo with the
patternsArray
length to prevent an Out of Bounds exception.While this fixes the error, the linear pattern itself is quite messy when running async:
I'm not sure if it's worth changing anything, as if you were to make it ordered then it would just look like the
#linear3d
pattern.Submitter Checklist
@since TODO
.